Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address autofill security concerns with copy changes #3211

Merged
merged 31 commits into from
Sep 19, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
ef2bca8
Add lock asset
graeme Aug 16, 2024
bc9faf9
Replace passwords subtitle with explainer view
graeme Aug 16, 2024
fd3f8ce
Add wip empty state text
graeme Aug 23, 2024
6da6b83
Show security info on clicking lock
graeme Sep 3, 2024
6b018eb
Fix empty state text
graeme Sep 4, 2024
104aee4
Update password explainer text
graeme Sep 4, 2024
3a39fd1
Add logic for showing import password explainer
graeme Sep 4, 2024
f8edc47
Hide security button based on autolock preferences
graeme Sep 4, 2024
5bf59bf
Make autolock off copy changes from Windows SR
graeme Sep 5, 2024
921da27
Fix crashy popover issue
graeme Sep 5, 2024
c6cb857
Fix settings link handling
graeme Sep 5, 2024
4d4560b
Fix settings link handing on Save info view
graeme Sep 5, 2024
d833a7a
Fix Settings casing
graeme Sep 5, 2024
2b3d5e1
Remove the and from the encrypted passwords message
graeme Sep 10, 2024
270bcda
More copy updates
graeme Sep 11, 2024
32d81a1
+ strings file
graeme Sep 11, 2024
f22aedd
Only show security button border when hovering
graeme Sep 11, 2024
e22b6f1
Make security info popover on hover
graeme Sep 13, 2024
2ce0c7a
Implement feedback on info tooltip view
graeme Sep 16, 2024
4ba21ba
Merge remote-tracking branch 'origin/main' into graeme/address-autofi…
graeme Sep 16, 2024
e857fdc
Remove duplicate string after main merge
graeme Sep 16, 2024
1cddd3b
Reduce auto-dismiss time
graeme Sep 16, 2024
cfbdd3d
Update lock hover view colours again
graeme Sep 17, 2024
e075a37
Fix dark mode by converting view to box
graeme Sep 18, 2024
cb88fc3
Lazy load the autolock var
graeme Sep 19, 2024
d0b7ece
Merge remote-tracking branch 'origin/main' into graeme/address-autofi…
graeme Sep 19, 2024
64e0d24
Use factory for autofill prefs to fix tests
graeme Sep 19, 2024
546e4d2
Revert "Use factory for autofill prefs to fix tests"
graeme Sep 19, 2024
93b1477
Revert "Lazy load the autolock var"
graeme Sep 19, 2024
2b10f74
Prevent Database assertion failure in dependencies
graeme Sep 19, 2024
664fb26
Prepend lock to empty screen message
graeme Sep 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prevent Database assertion failure in dependencies
  • Loading branch information
graeme committed Sep 19, 2024
commit 2b10f74bdbe73cfb9d7c6203a819fb2123ebf766
6 changes: 6 additions & 0 deletions DuckDuckGo/Preferences/Model/AutofillPreferences.swift
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,12 @@ final class AutofillPreferences: AutofillPreferencesPersistor {

private let injectedDependencyStore: StatisticsStore?
private lazy var defaultDependencyStore: StatisticsStore = {
#if DEBUG
// To prevent an assertion failure deep within dependencies in Database.makeDatabase
if [.unitTests, .xcPreviews].contains(NSApp.runType) {
return StubStatisticsStore()
}
#endif
return LocalStatisticsStore()
}()

Expand Down
20 changes: 20 additions & 0 deletions DuckDuckGo/Statistics/ATB/LocalStatisticsStore.swift
Original file line number Diff line number Diff line change
Expand Up @@ -231,3 +231,23 @@ final class LocalStatisticsStore: StatisticsStore {
}

}

#if DEBUG

// For use in tests to avoid indirect access of Database.makeDatabase

final class StubStatisticsStore: StatisticsStore {
var installDate: Date?
var atb: String?
var searchRetentionAtb: String?
var appRetentionAtb: String?
var variant: String?
var lastAppRetentionRequestDate: Date?

var waitlistUnlocked: Bool = false

var autoLockEnabled: Bool = false
var autoLockThreshold: String?
}

#endif
Loading