Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address autofill security concerns with copy changes #3211

Merged
merged 31 commits into from
Sep 19, 2024

Conversation

graeme
Copy link
Collaborator

@graeme graeme commented Sep 4, 2024

Task/Issue URL: https://app.asana.com/0/1199230911884351/1207411921782782/f

Description:
✓ Implement Survey for Password Manager Users showed that a proportion of users are hesitant to use our Password Manager because they don't know how secure it is. Easing these concerns should increase the adoption of DuckDuckGo's Password Manager.
These changes update and add copy to more clearly explain the security safe-guards of using the Password Manager.

Steps to test this PR:

  • Go to the screens from the designs in Figma and check they match. Double check Ship Review for any copy divergences.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link

github-actions bot commented Sep 4, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 664fb26

@graeme graeme requested a review from amddg44 September 10, 2024 15:46
@graeme graeme marked this pull request as ready for review September 10, 2024 15:46
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one note is that the DataImportViewModelTests seem to have broken (I tried running locally and it errors out there too)

Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes LGTM!

@graeme graeme merged commit 8c31e5d into main Sep 19, 2024
22 of 24 checks passed
@graeme graeme deleted the graeme/address-autofill-security-concerns branch September 19, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants