Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix api links #3209

Merged
merged 2 commits into from
Sep 26, 2017
Merged

fix api links #3209

merged 2 commits into from
Sep 26, 2017

Conversation

mairaw
Copy link
Contributor

@mairaw mairaw commented Sep 23, 2017

For some reason, api links using the old @ notation on this topic are broken:
https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/interpolated-strings

image

Need to see if this is a global issue. We have an issue tracking this change globally anyway: #787

Related to issue #3094

Copy link
Contributor

@JRAlexander JRAlexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mairaw
Copy link
Contributor Author

mairaw commented Sep 25, 2017

The problem was not that were using the @ notation but that the UID was wrong. This should fix the issue now.

@mairaw mairaw closed this Sep 26, 2017
@mairaw mairaw reopened this Sep 26, 2017
@mairaw mairaw merged commit 1ae4df4 into dotnet:master Sep 26, 2017
@mairaw mairaw deleted the mairaw-patch-2 branch September 26, 2017 21:57
BillWagner pushed a commit that referenced this pull request Sep 27, 2017
* mdoc CI update

* link poiting to azure instead of paper (#3222)

fixing link poiting to  the actual pdf

* Add missing parameter explanation. (#3003)

* Add missing parameter explanation.

* Add missing parameter explanation.

* addressed feedback

* csproj.md: Emphasise implicit version context (#3006)

* csproj.md: Emphasise implicit version context

Emphasises that `RuntimeFrameworkVersion` and `NetStandardImplicitPackageVersion` only apply to .NET Core and .NET Standard projects respectively.

* Update recommendation on metapackages

* Wording changes

* Small wording change

* Corrected typo in Standard Numeric Format Strings (#3219)

* Fix typos in return.md (#3220)

* Fix typos in return.md

* Update return.md

* Fixed a spelling mistake (#3228)

'true' -> 'false' in the example section

* Update using-on-windows-full-solution.md (#3216)

* fixed multiple typos in f# signatures chapter (#3231)

* manually remove dups

* fixed metadata values (#3226)

* fix api links (#3209)

* fix api links

* fixed uids

* use asp.net 4.x to mean non-core asp.net (#3230)

* use asp.net 4.x to mean non-core asp.net

* update link text

* BUG 107525 Typo in WebRequest.Create topic (#3148)

* BUG 107525 Typo in WebRequest.Create topic

* Changing all "the .NET Framework" to ".NET"

* Reverting the System.Obsolete strings

* Fixing pre-existing build warning (broken link)

* Fixing bad links

* Fix frameworks in runtime store doc (#2949)

* Removes `net47` directory.
* Fixes the `dotnet store` example with valid arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants