csproj.md: Emphasise implicit version context #3006

dasMulli · 2017-08-27T14:57:28Z

Emphasises that RuntimeFrameworkVersion and NetStandardImplicitPackageVersion only apply to .NET Core and .NET Standard projects respectively.

Context: NuGet/Home#5809 - User expected NetStandardImplicitPackageVersion to work for a .NET Framework project.

Emphasises that `RuntimeFrameworkVersion` and `NetStandardImplicitPackageVersion` only apply to .NET Core and .NET Standard projects respectively.

dnfclas · 2017-08-27T14:57:34Z

@dasMulli,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

mairaw

Thanks @dasMulli for following up on the issue and creating a PR for it. I think your changes greatly enhance the topic. I left a few comments to be addressed.

mairaw · 2017-08-28T18:17:44Z

docs/core/tools/csproj.md

@@ -33,10 +33,10 @@ Metapackages are implicitly referenced based on the target framework(s) specifie
 ### Recommendations
 Since `Microsoft.NETCore.App` or `NetStandard.Library` metapackages are implicitly referenced, the following are our recommended best practices:

-* Never have an explicit reference to the `Microsoft.NETCore.App` or `NetStandard.Library` metapackages via a `<PackageReference>` item in your project file.
-* If you need a specific version of the runtime, you should use the `<RuntimeFrameworkVersion>` property in your project (for example, `1.0.4`) instead of referencing the metapackage.
+* Never have an explicit reference to the `Microsoft.NETCore.App` or `NetStandard.Library` metapackages via a `<PackageReference>` item in your project file when trageting .NET Core or .NET Standard.


typo: tagreting
I'd also start with the condition: When targeting ..., never have ...

Also wondering if we want to be more explicit about the .NET Framework case here too?

dasMulli · 2017-08-28T19:05:46Z

docs/core/tools/csproj.md

    * This might happen if you are using [self-contained deployments](../deploying/index.md#self-contained-deployments-scd) and you need a specific patch version of 1.0.0 LTS runtime, for example.
-* If you need a specific version of the `NetStandard.Library` metapackage, you can use the `<NetStandardImplicitPackageVersion>` property and set the version you need. 
+* If you need a specific version of the `NetStandard.Library` metapackage when targeting .NET Standard, you can use the `<NetStandardImplicitPackageVersion>` property and set the version you need.
+* Do not explicitly add or update references to either the `Microsoft.NETCore.App` or `NetStandard.Library` metapackage in .NET Framework projects. If any version of `NetStandard.Library` should really be needed when using a .NET Standard based NuGet package, NuGet will automatically install the needed version.


@mairaw I've added this bullet point on .NET Framework. I'm a little worried about updating versions of NETStandard.Library since 2.0.0 is bringing in targets and assemblies for ns2.0 support that might be dangerous if the user already has System.* packages installed in a packages.config project and no ns2.0 support installed.

dasMulli · 2017-09-01T16:36:42Z

Changed wording based on feedback from @guardrex on slack

dasMulli · 2017-09-23T16:16:10Z

@mairaw could you take a look? any more changes necessary or ready to go?

mairaw

@dasMulli so sorry I dropped the ball on this one. I have a small suggestion. Let me know what you think before I merge this.

mairaw · 2017-09-25T05:38:31Z

docs/core/tools/csproj.md

@@ -37,7 +37,7 @@ Since `Microsoft.NETCore.App` or `NetStandard.Library` metapackages are implicit
 * If you need a specific version of the runtime when targeting .NET Core, you should use the `<RuntimeFrameworkVersion>` property in your project (for example, `1.0.4`) instead of referencing the metapackage.
    * This might happen if you are using [self-contained deployments](../deploying/index.md#self-contained-deployments-scd) and you need a specific patch version of 1.0.0 LTS runtime, for example.
 * If you need a specific version of the `NetStandard.Library` metapackage when targeting .NET Standard, you can use the `<NetStandardImplicitPackageVersion>` property and set the version you need.
-* Do not explicitly add or update references to either the `Microsoft.NETCore.App` or `NetStandard.Library` metapackage in .NET Framework projects. If any version of `NetStandard.Library` should really be needed when using a .NET Standard based NuGet package, NuGet will automatically install the needed version.
+* Don't explicitly add or update references to either the `Microsoft.NETCore.App` or `NetStandard.Library` metapackage in .NET Framework projects. If any version of `NetStandard.Library` is needed when using a .NET Standard-based NuGet package, NuGet automatically installs the needed version.


suggestion: install the needed version -> installs that version

much better, changed it

Cool. I'll merge when build finishes. Thanks @dasMulli and apologies again on the delay. Feel free to ping me when I'm taking more than a few days to respond.

dnfclas · 2017-09-25T16:53:27Z

@dasMulli,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

dnfclas · 2017-09-26T06:37:08Z

@dasMulli,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

* mdoc CI update * link poiting to azure instead of paper (#3222) fixing link poiting to the actual pdf * Add missing parameter explanation. (#3003) * Add missing parameter explanation. * Add missing parameter explanation. * addressed feedback * csproj.md: Emphasise implicit version context (#3006) * csproj.md: Emphasise implicit version context Emphasises that `RuntimeFrameworkVersion` and `NetStandardImplicitPackageVersion` only apply to .NET Core and .NET Standard projects respectively. * Update recommendation on metapackages * Wording changes * Small wording change * Corrected typo in Standard Numeric Format Strings (#3219) * Fix typos in return.md (#3220) * Fix typos in return.md * Update return.md * Fixed a spelling mistake (#3228) 'true' -> 'false' in the example section * Update using-on-windows-full-solution.md (#3216) * fixed multiple typos in f# signatures chapter (#3231) * manually remove dups * fixed metadata values (#3226) * fix api links (#3209) * fix api links * fixed uids * use asp.net 4.x to mean non-core asp.net (#3230) * use asp.net 4.x to mean non-core asp.net * update link text * BUG 107525 Typo in WebRequest.Create topic (#3148) * BUG 107525 Typo in WebRequest.Create topic * Changing all "the .NET Framework" to ".NET" * Reverting the System.Obsolete strings * Fixing pre-existing build warning (broken link) * Fixing bad links * Fix frameworks in runtime store doc (#2949) * Removes `net47` directory. * Fixes the `dotnet store` example with valid arguments

csproj.md: Emphasise implicit version context

7c64f44

Emphasises that `RuntimeFrameworkVersion` and `NetStandardImplicitPackageVersion` only apply to .NET Core and .NET Standard projects respectively.

dnfclas added the cla-already-signed label Aug 27, 2017

dasMulli mentioned this pull request Aug 27, 2017

NetStandardImplicitPackageVersion ignored for .NET Framework NuGet/Home#5809

Closed

mairaw requested changes Aug 28, 2017

View reviewed changes

mairaw requested a review from nguerrera August 28, 2017 18:26

Update recommendation on metapackages

97293b9

dasMulli commented Aug 28, 2017

View reviewed changes

nguerrera approved these changes Aug 28, 2017

View reviewed changes

rohit21agrawal mentioned this pull request Aug 29, 2017

NetStandardImplicitPackageVersion ignored for .NET Framework dotnet/sdk#1550

Closed

Wording changes

40b16ae

mairaw approved these changes Sep 25, 2017

View reviewed changes

Small wording change

951c4a4

mairaw added the verify-build-before-merge label Sep 25, 2017

mairaw closed this Sep 25, 2017

mairaw reopened this Sep 25, 2017

dnfclas added the cla-already-signed label Sep 25, 2017

mairaw closed this Sep 26, 2017

mairaw reopened this Sep 26, 2017

dnfclas added the cla-already-signed label Sep 26, 2017

BillWagner merged commit b037267 into dotnet:master Sep 26, 2017

mairaw removed the verify-build-before-merge label Oct 20, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

csproj.md: Emphasise implicit version context #3006

csproj.md: Emphasise implicit version context #3006

dasMulli commented Aug 27, 2017

dnfclas commented Aug 27, 2017

mairaw left a comment

mairaw Aug 28, 2017

dasMulli Aug 28, 2017

dasMulli Aug 28, 2017

nguerrera Aug 28, 2017

dasMulli commented Sep 1, 2017 •

edited

Loading

dasMulli commented Sep 23, 2017

mairaw left a comment

mairaw Sep 25, 2017

dasMulli Sep 25, 2017

mairaw Sep 25, 2017

dnfclas commented Sep 25, 2017

dnfclas commented Sep 26, 2017

csproj.md: Emphasise implicit version context #3006

csproj.md: Emphasise implicit version context #3006

Conversation

dasMulli commented Aug 27, 2017

dnfclas commented Aug 27, 2017

mairaw left a comment

Choose a reason for hiding this comment

mairaw Aug 28, 2017

Choose a reason for hiding this comment

dasMulli Aug 28, 2017

Choose a reason for hiding this comment

dasMulli Aug 28, 2017

Choose a reason for hiding this comment

nguerrera Aug 28, 2017

Choose a reason for hiding this comment

dasMulli commented Sep 1, 2017 • edited Loading

dasMulli commented Sep 23, 2017

mairaw left a comment

Choose a reason for hiding this comment

mairaw Sep 25, 2017

Choose a reason for hiding this comment

dasMulli Sep 25, 2017

Choose a reason for hiding this comment

mairaw Sep 25, 2017

Choose a reason for hiding this comment

dnfclas commented Sep 25, 2017

dnfclas commented Sep 26, 2017

dasMulli commented Sep 1, 2017 •

edited

Loading