Remove en-us from links #2581
Remove en-us from links #2581
Conversation
| @@ -9,7 +9,7 @@ may be either trademarks or registered trademarks of Microsoft in the United Sta | |||
| The licenses for this project do not grant you rights to use any Microsoft names, logos, or trademarks. | |||
| Microsoft's general trademark guidelines can be found at http://go.microsoft.com/fwlink/?LinkID=254653. | |||
|
|
|||
| Privacy information can be found at https://privacy.microsoft.com/en-us/ | |||
| Privacy information can be found at https://privacy.microsoft.com/ | |||
There was a problem hiding this comment.
I wouldn't touch the legal notices. they were pre-approved by the legal team and must remain as-is
There was a problem hiding this comment.
Ok ... and there are also broken links in the repo that point to a default.aspx privacy page that lands on a 404. I'm going to close this PR and reopen with a set of changes that don't touch the privacy links. I'll set up an issue to cover the privacy link updates to get those broken ones (404) to the correct address.
| @@ -71,6 +71,6 @@ Provides methods that enable the host to start and stop the common language runt | |||
| <xref:System.AppDomain> | |||
| [Hosting](../../../../docs/framework/unmanaged-api/hosting/index.md) | |||
| [ICLRRuntimeHost Interface](../../../../docs/framework/unmanaged-api/hosting/iclrruntimehost-interface.md) | |||
| [Runtime Hosts](http://msdn.microsoft.com/en-us/99d9246a-b994-4fe5-985c-8588d1d59998) | |||
| [Runtime Hosts](http://msdn.microsoft.com/99d9246a-b994-4fe5-985c-8588d1d59998) | |||
There was a problem hiding this comment.
ideally we'd add library to these links. otherwise customers can't get to versions that work. even better would be to link to a previous version that work but you can't tell by looking at the link
There was a problem hiding this comment.
@mairaw Yes, this was a "low hanging fruit" PR to just get en-us out. Do you want me to rerun the script to ignore the msdn.microsoft.com links so that those can be addressed in a future issue/PR? That way, we'd be fixing the more stable/long-term links with my PR?
🔪
en-us(ignore casing) from links in repo.Fixes #2580
@mairaw This is a global removal. If there are any links where
en-usshould be retained, I'll re-run based on your filter(s) criteria.