Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links (remove en-us+update MSDN links) #2580

Closed
5 of 8 tasks
guardrex opened this issue Jul 9, 2017 · 6 comments
Closed
5 of 8 tasks

Update links (remove en-us+update MSDN links) #2580

guardrex opened this issue Jul 9, 2017 · 6 comments
Labels
doc-bug Problem with the content; needs to be fixed [org][type][category]
Milestone

Comments

@guardrex
Copy link
Contributor

guardrex commented Jul 9, 2017

@mairaw I'll break these into batches on separate PRs:

@guardrex guardrex added the doc-bug Problem with the content; needs to be fixed [org][type][category] label Jul 9, 2017
@guardrex guardrex added this to the July 2017 milestone Jul 9, 2017
@guardrex guardrex self-assigned this Jul 9, 2017
@guardrex guardrex changed the title Remove en-us from links Update links (remove en-us+update MSDN links) Jul 14, 2017
@mairaw
Copy link
Contributor

mairaw commented Jul 18, 2017

Make sure you keep links inside the microservices book absolute.

@guardrex
Copy link
Contributor Author

@mairaw "microservices book" == all of the topics under docs/standard/microservices-architecture?

Are there any other areas of the TOC where we want absolute links?

@BillWagner
Copy link
Member

Is this and #2037 duplicates?

@guardrex
Copy link
Contributor Author

@BillWagner These updates started with merely the goal of dropping en-us from links, then this was expanded to get rid of GUID-based MSDN links [either in favor of library-based MSDN links or OPS links (if the MSDN page redirects to an OPS topic)], update some privacy links, and fix some absolute links.

I think #2037 covers dealing more thoroughly with the entire MSDN and fwlink situation, and we've only done that lightly here.

The scripts I've used grab the canonical link from redirected responses to drop MSDN links where possible (especially the GUID-based ones in favor of the library-based ones), but as @mairaw already corrected on one of the PR's here, there's apparently many of them that won't get their correct OPS links. They simply didn't redirect to an OPS topic, so the script took the MSDN page at its library-based endpoint address for the link.

I think #2037 should be left open and worked on after this issue is resolved. The work on this issue pushes things in the right direction imo.

@guardrex
Copy link
Contributor Author

@mairaw Unassigning now ... I won't be able to address this issue further in the time remaining with the issues that I can finish by Monday night.

@guardrex guardrex removed their assignment Jul 28, 2017
@mairaw mairaw modified the milestones: Backlog, July 2017 Aug 7, 2017
@mairaw
Copy link
Contributor

mairaw commented Sep 18, 2017

Closing this since we have #2037 tracking this change more broadly.

@mairaw mairaw closed this as completed Sep 18, 2017
@mairaw mairaw modified the milestones: Backlog, August 2017 Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-bug Problem with the content; needs to be fixed [org][type][category]
Projects
None yet
Development

No branches or pull requests

3 participants