Redis as a Deployment kind #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadeusz-delphai
changed the title
tplessas
approved these changes
Nov 29, 2023
anton-delphai
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we change the redis workload kind from the default
StatefulSetto a simplerDeployment.During the deployment, new redis-master pods will be created, but the
[service]-redis-masterService will stay the same, and the newEndpointswill be practically identical to the old ones - with the same labels, only with different timestamp metadata etc.===
Tested on review using the page-scraper service
https://app.delphai.pink/service/page-scraper-deployment-kind/===
As a side-note, the
Chart.lockgets updated to specify that we deploy redis based on Chart 17.17.1, not an older version. This is what actually is used in production.