Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: redis as Deployment, not StatefulSet. #69

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

tadeusz-delphai
Copy link
Contributor

No description provided.

@tadeusz-delphai tadeusz-delphai requested a review from a team as a code owner November 27, 2023 14:49
@tadeusz-delphai tadeusz-delphai force-pushed the redis-workload-deployment-not-statefulset branch from a20dcc7 to cb6e99e Compare November 27, 2023 14:53
tplessas
tplessas previously approved these changes Nov 27, 2023
@anton-delphai
Copy link
Contributor

Did you test it? Is it that transparent change?
Will it apply newer chart to existing releases?

@tadeusz-delphai
Copy link
Contributor Author

Did you test it? Is it that transparent change?
Will it apply newer chart to existing releases?

This definitely deserves some QA in review.

@tadeusz-delphai
Copy link
Contributor Author

A test version of the page-scraper service got deployed in the review cluster.

$> kubectl get deployments -n page-scraper -l app.kubernetes.io/name=redis
NAME                                        READY   UP-TO-DATE   AVAILABLE   AGE
page-scraper-test-redis-deployment-master   1/1     1            1           18m

@tadeusz-delphai
Copy link
Contributor Author

tadeusz-delphai commented Nov 28, 2023

Did you test it?

Yes, @hennadii-delphai and I tested it in review. There's a page-scraper-test-redis-deployment release in the review environment. It works just fine.

Is it that transparent change?

It's as transparent as any new version of the delphai-deployment Helm Chart, e.g. #58 . There'll be a new helm release deployed through the usual GitHub Actions CI mechanism.

Will it apply newer chart to existing releases?

For each of the affected services we'll trigger a re-release for the master branch.

@tadeusz-delphai tadeusz-delphai requested a review from a team November 28, 2023 14:30
@tplessas tplessas merged commit 1303f34 into master Nov 28, 2023
2 checks passed
@tplessas tplessas deleted the redis-workload-deployment-not-statefulset branch November 28, 2023 14:32
@anton-delphai
Copy link
Contributor

It's as transparent as any new version of the delphai-deployment Helm Chart, e.g. #58 . There'll be a new helm release deployed through the usual GitHub Actions CI mechanism.

I asked another thing. Is it possible to upgrade existing statefulset-based release to new one in place?

tadeusz-delphai added a commit that referenced this pull request Nov 28, 2023
tadeusz-delphai added a commit that referenced this pull request Nov 28, 2023
tadeusz-delphai added a commit that referenced this pull request Nov 28, 2023
Revert "chore: redis as Deployment, not StatefulSet. (#69)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants