Skip to content

Commit

Permalink
build: configure return exit status from gyp
Browse files Browse the repository at this point in the history
Previously, 'configure' would not return an exit status
if gyp blows up. This can be tested via:

    date >> node.gyp ; ./configure && echo A-OK

You will get "A-OK" even though gyp had failed.

PR-URL: nodejs/node-v0.x-archive#8856
Reviewed-By: Ben Noordhuis <[email protected]>
  • Loading branch information
srl295 authored and bnoordhuis committed Dec 10, 2014
1 parent 687dfc9 commit fb33b4e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion configure
Original file line number Diff line number Diff line change
Expand Up @@ -877,4 +877,4 @@ else:

gyp_args += args

subprocess.call(gyp_args)
sys.exit(subprocess.call(gyp_args))

0 comments on commit fb33b4e

Please sign in to comment.