This repository has been archived by the owner on Apr 22, 2023. It is now read-only.
build: configure return exit status from gyp #8856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, 'configure' would not return an exit status
if gyp blows up. This can be tested via:
date >> node.gyp ; ./configure && echo A-OK
You will get "A-OK" even though gyp had failed.
bnoordhuis
pushed a commit
to nodejs/node
that referenced
this pull request
Dec 10, 2014
Previously, 'configure' would not return an exit status
if gyp blows up. This can be tested via:
date >> node.gyp ; ./configure && echo A-OK
You will get "A-OK" even though gyp had failed.
PR-URL: nodejs/node-v0.x-archive#8856
Reviewed-By: Ben Noordhuis <[email protected]>
|
Thanks Steven, landed in nodejs/node@fb33b4e. |
|
@srl295 Thanks! Landed in v0.10 in 69b122a. Will be merged in v0.12 and master later, I just want to check with @tjfontaine first when would be the best time for that. |
|
Just FYI, we will wait until 0.11.15 is released to merge v0.10 into v0.12. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, 'configure' would not return an exit status
if gyp blows up. This can be tested by adding some garbage to
node.gyp(I have skills!)You will get "A-OK" even though gyp had failed.
( Found this while working on srl295/node#12 )