Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Progress bars for dm_wrap_tbl() and dm_unwrap_tbl() #1450

Merged
merged 5 commits into from
Mar 14, 2023
Merged

feat: Progress bars for dm_wrap_tbl() and dm_unwrap_tbl() #1450

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
70a0395
Implement progress bars for dm_wrap_tbl and dm_unwrap_tbl
moodymudskipper Sep 2, 2022
cdb53dd
Auto-update from GitHub Actions
moodymudskipper Sep 2, 2022
c27fa55
Merge branch 'main' into f-835-more-progress-bars
krlmlr Feb 10, 2023
e22420c
Merge branch 'main' into f-835-more-progress-bars
krlmlr Mar 14, 2023
a04f29f
Recover from invalid merge conflict resolution
krlmlr Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into f-835-more-progress-bars
  • Loading branch information
@krlmlr
krlmlr committed Feb 10, 2023
commit c27fa556f56124929e5ae5caff38e729b8ddd0d1
4 changes: 3 additions & 1 deletion R/dm_wrap.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,9 @@ dm_unwrap_tbl <- function(dm, ptype, progress = NA) {

unwrapped_dm <- reduce(
transpose(unwrap_plan),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I add this call accidentally when resolving conflicts?

ticker(function(dm, row) exec(row$action, dm, row$table, row$col, ptype)),
function(dm, row) {
exec(row$action, dm, row$table, row$col, ptype)
},
.init = dm
)
unwrapped_dm
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.