Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Progress bars for dm_wrap_tbl() and dm_unwrap_tbl() #1450

Merged
merged 5 commits into from
Mar 14, 2023

Conversation

moodymudskipper
Copy link
Collaborator

@moodymudskipper moodymudskipper commented Sep 2, 2022

After #1447

Closes #835 unless we also want pb for the deprecated dm_apply_filters()

@krlmlr
Copy link
Collaborator

krlmlr commented Sep 5, 2022

Waiting for the linked PR.

Copy link
Collaborator

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we could set aside a few days here to wrap up all the loose ends...

R/dm_wrap.R Outdated
unwrapped_dm <- reduce(
unwrap_plan,
transpose(unwrap_plan),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I add this call accidentally when resolving conflicts?

@krlmlr krlmlr changed the title Progress bars for dm_wrap_tbl() and dm_unwrap_tbl() feat: Progress bars for dm_wrap_tbl() and dm_unwrap_tbl() Mar 14, 2023
@krlmlr krlmlr merged commit 010947c into main Mar 14, 2023
@krlmlr krlmlr deleted the f-835-more-progress-bars branch March 14, 2023 17:09
@krlmlr
Copy link
Collaborator

krlmlr commented Mar 14, 2023

Thanks!

krlmlr added a commit that referenced this pull request Mar 17, 2023
dm 1.0.5

- Progress bars for `dm_wrap_tbl()` and `dm_unwrap_tbl()` (#835, #1450).

- Add cheat sheet as a vignette (#1653).

- Suggest creating a function for your database `dm` object (#1827, #1828).

- Add alternative text to author images for pkgdown website (#1804).

- Compatibility with dev jsonlite (#1837).

- Remove tidyverse dependency (#1798, #1834).

- Minimal patch to fix multiple match updates (@DavisVaughan, #1806).

- Adapt to rlang 1.1.0 changes (#1817).

- Make sure `{dm}` passes "noSuggests" workflow (#1659).
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

More progress bars
2 participants