-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Progress bars for dm_wrap_tbl() and dm_unwrap_tbl() #1450
Conversation
Waiting for the linked PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish we could set aside a few days here to wrap up all the loose ends...
R/dm_wrap.R
Outdated
unwrapped_dm <- reduce( | ||
unwrap_plan, | ||
transpose(unwrap_plan), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did I add this call accidentally when resolving conflicts?
Thanks! |
dm 1.0.5 - Progress bars for `dm_wrap_tbl()` and `dm_unwrap_tbl()` (#835, #1450). - Add cheat sheet as a vignette (#1653). - Suggest creating a function for your database `dm` object (#1827, #1828). - Add alternative text to author images for pkgdown website (#1804). - Compatibility with dev jsonlite (#1837). - Remove tidyverse dependency (#1798, #1834). - Minimal patch to fix multiple match updates (@DavisVaughan, #1806). - Adapt to rlang 1.1.0 changes (#1817). - Make sure `{dm}` passes "noSuggests" workflow (#1659).
After #1447
Closes #835 unless we also want pb for the deprecated dm_apply_filters()