Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Unrated Decreases to Validator Commission Rates #3918

Merged
merged 4 commits into from
Mar 20, 2019
Merged

Allow Unrated Decreases to Validator Commission Rates #3918

merged 4 commits into from
Mar 20, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Mar 16, 2019 •
edited
Loading

closes: #3917

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Mar 17, 2019 •
edited
Loading

Codecov Report

Merging #3918 into develop will increase coverage by 0.08%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3918      +/-   ##
===========================================
+ Coverage    60.26%   60.35%   +0.08%     
===========================================
  Files          196      196              
  Lines        14615    14615              
===========================================
+ Hits          8808     8821      +13     
+ Misses        5214     5201      -13     
  Partials       593      593

@alexanderbez alexanderbez marked this pull request as ready for review March 17, 2019 02:03
@alexanderbez alexanderbez added the T: State Machine Breaking State machine breaking changes (impacts consensus). label Mar 17, 2019
rigelrozanski
rigelrozanski approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

x/staking/types/commission_test.go Show resolved Hide resolved
cwgoes
cwgoes approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, great testcase coverage.

@rigelrozanski rigelrozanski merged commit 386116f into develop Mar 20, 2019
@rigelrozanski rigelrozanski deleted the bez/3917-de-throttle-commission-rate-decrease branch March 20, 2019 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@cwgoes cwgoes cwgoes approved these changes

@ebuchman ebuchman Awaiting requested review from ebuchman

@alessio alessio Awaiting requested review from alessio

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@mossid mossid Awaiting requested review from mossid

Assignees
No one assigned
Labels
C:x/staking T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rate-limit commission *increases* only
3 participants
@alexanderbez @rigelrozanski @cwgoes