Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate-limit commission *increases* only #3917

Closed
cwgoes opened this issue Mar 16, 2019 · 2 comments · Fixed by #3918
Closed

Rate-limit commission *increases* only #3917

cwgoes opened this issue Mar 16, 2019 · 2 comments · Fixed by #3918
Assignees
Labels
C:x/staking T: State Machine Breaking State machine breaking changes (impacts consensus).
Milestone

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Mar 16, 2019

Ref https://github.com/cosmos/cosmos-sdk/blob/develop/x/staking/types/commission.go#L122

There's no reason we need to rate-limit commission rate decreases (that I can think of).

This is quite annoying.

cc @rigelrozanski Can you think of any reason to rate-limit decreases I'm missing?

@cwgoes cwgoes added this to the v0.34.0 milestone Mar 16, 2019
@rigelrozanski
Copy link
Contributor

rigelrozanski commented Mar 16, 2019

You're correct, if you're decreasing your commission there is no good reason to rate limit - we ought to remove that .Abs()

@alexanderbez alexanderbez self-assigned this Mar 16, 2019
@alexanderbez
Copy link
Contributor

This was done by me as it was the definition of commission rate change I had at the time of implementation -- i.e. any change should be rate limited. I see this is not desirable obviously so I'll go ahead and fix this asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/staking T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants