Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom settings #22

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Support custom settings #22

merged 2 commits into from
Jul 4, 2019

Conversation

winebarrel
Copy link
Contributor

@winebarrel winebarrel commented Jul 4, 2019 •
edited
Loading

Fix to pass settings info when creating a server.

server = GrpcKit::Server.new([
  [DS9::Settings::MAX_FRAME_SIZE, 65535]
])

@ganmacs Please review PR 🙏

ganmacs
ganmacs reviewed Jul 4, 2019
View reviewed changes
lib/grpc_kit/server.rb Outdated Show resolved Hide resolved
@winebarrel
Copy link
Contributor Author

Thank you!!

@winebarrel winebarrel merged commit 45cff94 into cookpad:master Jul 4, 2019
@winebarrel winebarrel deleted the fix_submit_settings branch July 4, 2019 08:01
This was referenced Jul 4, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganmacs ganmacs ganmacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winebarrel @ganmacs