Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support submiting HTTP2-Settings header #5

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Support submiting HTTP2-Settings header #5

merged 2 commits into from
Jul 4, 2019

Conversation

winebarrel
Copy link
Contributor

Fix to submit HTTP2-Settings header from server.
cf. cookpad/grpc_kit#22

Griffin::Server.configure do |c|
  c.http2_settings [[DS9::Settings::MAX_FRAME_SIZE, 655350]]
end

@cookpad/infra @ganmacs Please review PR 🙏

ganmacs
ganmacs approved these changes Jul 4, 2019
View reviewed changes
lib/griffin/server.rb Outdated
@@ -41,10 +41,11 @@ def config_builder
# @param min_connection_size [Integer] Maximun connection of TCP
# @param max_connection_size [Integer] Minimum connection of TCP
# @param interceptors [Array<GrpcKit::GRPC::ServerInterceptor>] list of interceptors
def initialize(min_pool_size:, max_pool_size:, min_connection_size:, max_connection_size:, interceptors: [], **opts)
# @param settings [Array<DS9::Settings,Integer> list of HTTP2-Settings headers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs ] after Integer>?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! fixed c961e98

@winebarrel
Copy link
Contributor Author

Thank you!!

@winebarrel winebarrel merged commit 9c9d2d5 into cookpad:master Jul 4, 2019
@winebarrel winebarrel deleted the support_http2_settings_header branch July 4, 2019 10:05
@winebarrel winebarrel mentioned this pull request Jul 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ganmacs ganmacs ganmacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winebarrel @ganmacs