Add metrics-server for Kubernetes HPA / stats #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with "install.sh" against Civo k3s Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
| @@ -0,0 +1,9 @@ | |||
| --- | |||
| name: metrics-server | |||
There was a problem hiding this comment.
Please could you name this as Metrics Server, the name is used as a title in display on the site.
There was a problem hiding this comment.
Actually, don't worry, I've made a change to the YAML format to allow for name to have a hyphen but a title for a nicer display version. I'll fix this post-merge.
metrics-server/post_install.md
Outdated
|
|
||
| ### Test it out | ||
|
|
||
| * Check that data is being received from nodes: |
There was a problem hiding this comment.
Would rather drop these bullet points, normal paragraphs work well when interspersed with code snippets. If you like I can change these after merging though.
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
DMajrekar
pushed a commit
that referenced
this pull request
Nov 2, 2023
pull latest changes from upstream civo repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with "install.sh" against Civo k3s
Signed-off-by: Alex Ellis (OpenFaaS Ltd) [email protected]