Skip to content

Commit

Permalink
isdn: Cleanup Sections in PCMCIA driver elsa
Browse files Browse the repository at this point in the history
Compiling this driver gave a section mismatch,
so I reviewed the init/exit paths of the driver
and made the correct changes.

WARNING: drivers/isdn/hisax/built-in.o(.text+0x55e37): Section mismatch
in reference from the function elsa_cs_config() to the function
.devinit.text:hisax_init_pcmcia()
The function elsa_cs_config() references
the function __devinit hisax_init_pcmcia().
This is often because elsa_cs_config lacks a __devinit
annotation or the annotation of hisax_init_pcmcia is wrong.

Signed-off-by: Henrik Kretzschmar <[email protected]>
Acked-by: Karsten Keil <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Henne authored and davem330 committed Mar 25, 2010
1 parent a465870 commit f61bb62
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/isdn/hisax/elsa_cs.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ module_param(protocol, int, 0);
handler.
*/

static int elsa_cs_config(struct pcmcia_device *link);
static int elsa_cs_config(struct pcmcia_device *link) __devinit ;
static void elsa_cs_release(struct pcmcia_device *link);

/*
Expand All @@ -85,7 +85,7 @@ static void elsa_cs_release(struct pcmcia_device *link);
needed to manage one actual PCMCIA card.
*/

static void elsa_cs_detach(struct pcmcia_device *p_dev);
static void elsa_cs_detach(struct pcmcia_device *p_dev) __devexit;

/*
A driver needs to provide a dev_node_t structure for each device
Expand Down Expand Up @@ -121,7 +121,7 @@ typedef struct local_info_t {
======================================================================*/

static int elsa_cs_probe(struct pcmcia_device *link)
static int __devinit elsa_cs_probe(struct pcmcia_device *link)
{
local_info_t *local;

Expand Down Expand Up @@ -166,7 +166,7 @@ static int elsa_cs_probe(struct pcmcia_device *link)
======================================================================*/

static void elsa_cs_detach(struct pcmcia_device *link)
static void __devexit elsa_cs_detach(struct pcmcia_device *link)
{
local_info_t *info = link->priv;

Expand Down Expand Up @@ -210,7 +210,7 @@ static int elsa_cs_configcheck(struct pcmcia_device *p_dev,
return -ENODEV;
}

static int elsa_cs_config(struct pcmcia_device *link)
static int __devinit elsa_cs_config(struct pcmcia_device *link)
{
local_info_t *dev;
int i;
Expand Down Expand Up @@ -327,7 +327,7 @@ static struct pcmcia_driver elsa_cs_driver = {
.name = "elsa_cs",
},
.probe = elsa_cs_probe,
.remove = elsa_cs_detach,
.remove = __devexit_p(elsa_cs_detach),
.id_table = elsa_ids,
.suspend = elsa_suspend,
.resume = elsa_resume,
Expand Down

0 comments on commit f61bb62

Please sign in to comment.