Skip to content

Commit

Permalink
isdn: Cleanup Sections in PCMCIA driver avma1
Browse files Browse the repository at this point in the history
Compiling this driver gave a section mismatch,
so I reviewed the init/exit paths of the driver
and made the correct changes.

WARNING: drivers/isdn/hisax/built-in.o(.text+0x56512): Section mismatch
in reference from the function avma1cs_config() to the function
.devinit.text:hisax_init_pcmcia()
The function avma1cs_config() references
the function __devinit hisax_init_pcmcia().
This is often because avma1cs_config lacks a __devinit
annotation or the annotation of hisax_init_pcmcia is wrong.

Signed-off-by: Henrik Kretzschmar <[email protected]>
Acked-by: Karsten Keil <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Henne authored and davem330 committed Mar 25, 2010
1 parent 158e33d commit a465870
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/isdn/hisax/avma1_cs.c
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ module_param(isdnprot, int, 0);
handler.
*/

static int avma1cs_config(struct pcmcia_device *link);
static int avma1cs_config(struct pcmcia_device *link) __devinit ;
static void avma1cs_release(struct pcmcia_device *link);

/*
Expand All @@ -59,7 +59,7 @@ static void avma1cs_release(struct pcmcia_device *link);
needed to manage one actual PCMCIA card.
*/

static void avma1cs_detach(struct pcmcia_device *p_dev);
static void avma1cs_detach(struct pcmcia_device *p_dev) __devexit ;


/*
Expand Down Expand Up @@ -99,7 +99,7 @@ typedef struct local_info_t {
======================================================================*/

static int avma1cs_probe(struct pcmcia_device *p_dev)
static int __devinit avma1cs_probe(struct pcmcia_device *p_dev)
{
local_info_t *local;

Expand Down Expand Up @@ -140,7 +140,7 @@ static int avma1cs_probe(struct pcmcia_device *p_dev)
======================================================================*/

static void avma1cs_detach(struct pcmcia_device *link)
static void __devexit avma1cs_detach(struct pcmcia_device *link)
{
dev_dbg(&link->dev, "avma1cs_detach(0x%p)\n", link);
avma1cs_release(link);
Expand Down Expand Up @@ -174,7 +174,7 @@ static int avma1cs_configcheck(struct pcmcia_device *p_dev,
}


static int avma1cs_config(struct pcmcia_device *link)
static int __devinit avma1cs_config(struct pcmcia_device *link)
{
local_info_t *dev;
int i;
Expand Down Expand Up @@ -282,7 +282,7 @@ static struct pcmcia_driver avma1cs_driver = {
.name = "avma1_cs",
},
.probe = avma1cs_probe,
.remove = avma1cs_detach,
.remove = __devexit_p(avma1cs_detach),
.id_table = avma1cs_ids,
};

Expand Down

0 comments on commit a465870

Please sign in to comment.