Skip to content

Commit

Permalink
isdn: Cleanup Sections in PCMCIA driver teles
Browse files Browse the repository at this point in the history
Compiling this driver gave a section mismatch,
so I reviewed the init/exit paths of the driver
and made the correct changes.

WARNING: drivers/isdn/hisax/built-in.o(.text+0x56bfb): Section mismatch
in reference from the function teles_cs_config() to the function
.devinit.text:hisax_init_pcmcia()
The function teles_cs_config() references
the function __devinit hisax_init_pcmcia().
This is often because teles_cs_config lacks a __devinit
annotation or the annotation of hisax_init_pcmcia is wrong.

Signed-off-by: Henrik Kretzschmar <[email protected]>
Acked-by: Karsten Keil <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Henne authored and davem330 committed Mar 25, 2010
1 parent 93b39a0 commit 158e33d
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/isdn/hisax/teles_cs.c
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ module_param(protocol, int, 0);
handler.
*/

static int teles_cs_config(struct pcmcia_device *link);
static int teles_cs_config(struct pcmcia_device *link) __devinit ;
static void teles_cs_release(struct pcmcia_device *link);

/*
Expand All @@ -66,7 +66,7 @@ static void teles_cs_release(struct pcmcia_device *link);
needed to manage one actual PCMCIA card.
*/

static void teles_detach(struct pcmcia_device *p_dev);
static void teles_detach(struct pcmcia_device *p_dev) __devexit ;

/*
A linked list of "instances" of the teles_cs device. Each actual
Expand Down Expand Up @@ -112,7 +112,7 @@ typedef struct local_info_t {
======================================================================*/

static int teles_probe(struct pcmcia_device *link)
static int __devinit teles_probe(struct pcmcia_device *link)
{
local_info_t *local;

Expand Down Expand Up @@ -156,7 +156,7 @@ static int teles_probe(struct pcmcia_device *link)
======================================================================*/

static void teles_detach(struct pcmcia_device *link)
static void __devexit teles_detach(struct pcmcia_device *link)
{
local_info_t *info = link->priv;

Expand Down Expand Up @@ -200,7 +200,7 @@ static int teles_cs_configcheck(struct pcmcia_device *p_dev,
return -ENODEV;
}

static int teles_cs_config(struct pcmcia_device *link)
static int __devinit teles_cs_config(struct pcmcia_device *link)
{
local_info_t *dev;
int i;
Expand Down Expand Up @@ -319,7 +319,7 @@ static struct pcmcia_driver teles_cs_driver = {
.name = "teles_cs",
},
.probe = teles_probe,
.remove = teles_detach,
.remove = __devexit_p(teles_detach),
.id_table = teles_ids,
.suspend = teles_suspend,
.resume = teles_resume,
Expand Down

0 comments on commit 158e33d

Please sign in to comment.