Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(popup-menu): allow to initially hide elements #748

Merged
merged 4 commits into from
Feb 6, 2023
Merged

feat(popup-menu): allow to initially hide elements #748

merged 4 commits into from
Feb 6, 2023

Commits on Feb 3, 2023

  1. test(popup-menu): ensure we await potential side-effects 

    This accounts for UI re-rendering to be async and consistently
handles it when causing effects, i.e. through initial rendering
or by triggering events.
    @nikku
    nikku committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    e6ad28b View commit details
    Browse the repository at this point in the history

  2. fix(popup-menu): filter entries eagerly 

    Prevents flickering during initial render.
    @nikku
    nikku committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    a18e3bc View commit details
    Browse the repository at this point in the history

  3. fix(popup-menu): register Escape listener only once

    @nikku
    nikku committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    26b7dbb View commit details
    Browse the repository at this point in the history

  4. feat(popup-menu): allow to initially hide elements 

    Allows integrators to assign a rank < 0 to entries to hide them from
the initial list of items. These items will appear once searched for.

Related to bpmn-io/bpmn-js#1621
    @nikku
    nikku committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    d798bb0 View commit details
    Browse the repository at this point in the history