feat(popup-menu): allow to initially hide elements #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
force-pushed
the
popup-menu-priority
branch
from
218715c
to
bd7ba9f
Compare
smbea
reviewed
Feb 3, 2023
|
The approach looks good but seems like we have some test failures. Feel free to tag me once that's ready too |
This accounts for UI re-rendering to be async and consistently handles it when causing effects, i.e. through initial rendering or by triggering events.
nikku
force-pushed
the
popup-menu-priority
branch
3 times, most recently
from
d5e662f
to
19ab48c
Compare
Prevents flickering during initial render.
Allows integrators to assign a rank < 0 to entries to hide them from the initial list of items. These items will appear once searched for. Related to bpmn-io/bpmn-js#1621
nikku
force-pushed
the
popup-menu-priority
branch
from
19ab48c
to
d798bb0
Compare
smbea
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows integrators to assign a
rank < 0to entries to hide them from the initial list of items. These items will appear once searched for.Related to bpmn-io/bpmn-js#1621