Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo install mdbook-svgbob failed #25

Closed
HollowMan6 opened this issue Feb 9, 2023 · 7 comments
Closed

cargo install mdbook-svgbob failed #25

HollowMan6 opened this issue Feb 9, 2023 · 7 comments

Comments

@HollowMan6
Copy link

Rust toolchain: 1.67.0

https://github.com/HollowMan6/mdbook-pdf/actions/runs/4134900407/jobs/7146633379

Compiling mdbook-svgbob v0.2.1
error[E0277]: the trait bound `Cfg: From<&toml::map::Map<std::string::String, toml::value::Value>>` is not satisfied
  --> /Users/runner/.cargo/registry/src/github.com-1ecc6299db9ec823/mdbook-svgbob-0.2.1/src/preprocessor.rs:58:38
   |
58 | ...                   .and_then(|map| map.try_into().map_err(|err| error!("{}", err)).ok())
   |                                       ^^^ -------- required by a bound introduced by this call
   |                                       |
   |                                       the trait `From<&toml::map::Map<std::string::String, toml::value::Value>>` is not implemented for `Cfg`
   |
   = note: required for `&toml::map::Map<std::string::String, toml::value::Value>` to implement `Into<Cfg>`
   = note: required for `Cfg` to implement `TryFrom<&toml::map::Map<std::string::String, toml::value::Value>>`
   = note: required for `&toml::map::Map<std::string::String, toml::value::Value>` to implement `TryInto<Cfg>`

For more information about this error, try `rustc --explain E0[277](https://github.com/HollowMan6/mdbook-pdf/actions/runs/4134900407/jobs/7146633379#step:6:278)`.
error: could not compile `mdbook-svgbob` due to previous error
@AtmanChen
Copy link

I have run into the same issue

@HollowMan6
Copy link
Author

I have run into the same issue

I have submitted a PR for fixing this, you can check it here:
#26

@AtmanChen
Copy link

I have run into the same issue

I have submitted a PR for fixing this, you can check it here: #26

Thank you~ I have installed it successfully in google's "comprehensive-rust" course.

@mgeisler
Copy link
Collaborator

Thanks @AtmanChen, I just noticed the same problem on our side 😄

mgeisler added a commit to mgeisler/comprehensive-rust that referenced this issue Feb 13, 2023
This will help avoid breakage[1] when mdbook and mdbook-svgbob are out
of sync with each other.

[1]: boozook/mdbook-svgbob#25.
mgeisler added a commit to mgeisler/comprehensive-rust that referenced this issue Feb 13, 2023
This will help avoid breakage[1] when mdbook and mdbook-svgbob are out
of sync with each other.

[1]: boozook/mdbook-svgbob#25.
@ehuss
Copy link

ehuss commented Feb 13, 2023

Sorry, I did not realize that toml was in the public API. I'm going to yank the release and revert the change, there shouldn't need to be anything you need to do.

@HollowMan6
Copy link
Author

Closing as this has been addressed.

mgeisler added a commit to google/comprehensive-rust that referenced this issue Feb 16, 2023
This will help avoid breakage[1] when mdbook and mdbook-svgbob are out
of sync with each other.

[1]: boozook/mdbook-svgbob#25.
NoahDragon pushed a commit to wnghl/comprehensive-rust that referenced this issue Jul 19, 2023
This will help avoid breakage[1] when mdbook and mdbook-svgbob are out
of sync with each other.

[1]: boozook/mdbook-svgbob#25.
@DannyRavi
Copy link

cargo install mdbook-svgbob --locked --version 0.2.1

worked for me!!!

GoldenPath1109 added a commit to GoldenPath1109/comprehesive-rust that referenced this issue Sep 2, 2024
This will help avoid breakage[1] when mdbook and mdbook-svgbob are out
of sync with each other.

[1]: boozook/mdbook-svgbob#25.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants