Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumping toml broken mdbook-svgbob #2019

Closed
mgeisler opened this issue Feb 13, 2023 · 6 comments
Closed

Bumping toml broken mdbook-svgbob #2019

mgeisler opened this issue Feb 13, 2023 · 6 comments
Labels
C-bug Category: A bug, incorrect or unintended behavior

Comments

@mgeisler
Copy link
Contributor

Problem

The update of the toml dependency broke mdbook-svgbob: boozook/mdbook-svgbob#25.

The change was made in 0e1384b. From looking at the diff alone, I'm not actually sure how bumping a transitive dependency like this could break mdbook-svgbob.

Steps

No response

Possible Solution(s)

Perhaps this should have been released as a 0.5.0 release?

Notes

No response

Version

0.4.26
@mgeisler mgeisler added the C-bug Category: A bug, incorrect or unintended behavior label Feb 13, 2023
@mgeisler mgeisler changed the title La Bumping toml broken mdbook-svgbob Feb 13, 2023
@ehuss
Copy link
Contributor

ehuss commented Feb 13, 2023

Thanks for the report! Sorry about the interruption, that was not intentional.
Closing as fixed by #2021. I'll publish a new version shortly.

@ehuss ehuss closed this as completed Feb 13, 2023
@mgeisler
Copy link
Contributor Author

Sorry about the interruption, that was not intentional.
Closing as fixed by #2021. I'll publish a new version shortly.

I mostly wanted to let you know — mdbook-svgbob is being updated too (boozook/mdbook-svgbob#26) so perhaps you don't want to revert the change.

@mgeisler
Copy link
Contributor Author

perhaps you don't want to revert the change.

Ah, you write in #2021 that this accidentally changed the public API — a revert sounds good then.

@HollowMan6 HollowMan6 mentioned this issue Feb 13, 2023
Merged
This was referenced Aug 2, 2023
Merged
Closed
@mgeisler
Copy link
Contributor Author

mgeisler commented Aug 2, 2023

Hi @ehuss, I think the update in #2125 triggered this again. I haven't looked at the details, but perhaps it would be possible to forward-fix this with a change to the toml crate?

@ehuss
Copy link
Contributor

ehuss commented Aug 2, 2023

Sorry about that. I completely forgot about that issue. The update has been reverted in #2151. I also put a comment to remember next time. I'll try to get a new release out soonish.

@ovo-Tim
Copy link

ovo-Tim commented Aug 3, 2023 •
edited
Loading

I have installed the latest version, but this problem still happens.

❯ cargo install --path .
  Installing mdbook v0.4.32 (/tmp/下载/mdBook-master)
    Updating crates.io index
   Compiling proc-macro2 v1.0.66
   Compiling libc v0.2.147
   Compiling unicode-ident v1.0.11
   Compiling autocfg v1.1.0
   Compiling cfg-if v1.0.0
   Compiling version_check v0.9.4
   Compiling log v0.4.19
   Compiling once_cell v1.18.0
   Compiling itoa v1.0.9
   Compiling thiserror v1.0.44
   Compiling bytes v1.4.0
   Compiling serde v1.0.180
   Compiling memchr v2.5.0
   Compiling bitflags v1.3.2
   Compiling typenum v1.16.0
   Compiling fnv v1.0.7
   Compiling serde_derive v1.0.180
   Compiling ppv-lite86 v0.2.17
   Compiling futures-core v0.3.28
   Compiling pin-project-lite v0.2.10
   Compiling rustix v0.38.6
   Compiling siphasher v0.3.10
   Compiling tinyvec_macros v0.1.1
   Compiling bitflags v2.3.3
   Compiling linux-raw-sys v0.4.5
   Compiling regex-syntax v0.7.4
   Compiling generic-array v0.14.7
   Compiling unicase v2.6.0
   Compiling tokio v1.29.1
   Compiling http v0.2.9
   Compiling phf_shared v0.10.0
   Compiling slab v0.4.8
   Compiling lock_api v0.4.10
   Compiling tinyvec v1.6.0
   Compiling parking_lot_core v0.9.8
   Compiling utf-8 v0.7.6
   Compiling io-lifetimes v1.0.11
   Compiling quote v1.0.32
   Compiling percent-encoding v2.3.0
   Compiling getrandom v0.2.10
   Compiling syn v2.0.28
   Compiling aho-corasick v1.0.2
   Compiling rand_core v0.6.4
   Compiling futures-task v0.3.28
   Compiling futures-sink v0.3.28
   Compiling rand_chacha v0.3.1
   Compiling form_urlencoded v1.2.0
   Compiling httparse v1.8.0
   Compiling scopeguard v1.2.0
   Compiling syn v1.0.109
   Compiling rustix v0.37.23
   Compiling rand v0.8.5
   Compiling mio v0.8.8
   Compiling num_cpus v1.16.0
   Compiling socket2 v0.4.9
   Compiling unicode-normalization v0.1.22
   Compiling futures-util v0.3.28
   Compiling crypto-common v0.1.6
   Compiling block-buffer v0.10.4
   Compiling new_debug_unreachable v1.0.4
   Compiling smallvec v1.11.0
   Compiling unicode-bidi v0.3.13
   Compiling digest v0.10.7
   Compiling regex-automata v0.3.4
   Compiling phf_generator v0.10.0
   Compiling phf_codegen v0.10.0
   Compiling idna v0.4.0
   Compiling string_cache_codegen v0.5.2
   Compiling is-terminal v0.4.9
   Compiling indexmap v1.9.3
   Compiling tracing-core v0.1.31
   Compiling linux-raw-sys v0.3.8
   Compiling serde_json v1.0.104
   Compiling ryu v1.0.15
   Compiling crossbeam-utils v0.8.16
   Compiling mac v0.1.1
   Compiling pin-utils v0.1.0
   Compiling ucd-trie v0.1.6
   Compiling cpufeatures v0.2.9
   Compiling utf8parse v0.2.1
   Compiling tracing v0.1.37
   Compiling anstyle-parse v0.2.1
   Compiling sha1 v0.10.5
   Compiling futf v0.1.5
   Compiling parking_lot v0.12.1
   Compiling markup5ever v0.11.0
   Compiling url v2.4.0
   Compiling colorchoice v1.0.0
   Compiling precomputed-hash v0.1.1
   Compiling base64 v0.13.1
   Compiling anstyle-query v1.0.0
   Compiling same-file v1.0.6
   Compiling hashbrown v0.12.3
   Compiling futures-channel v0.3.28
   Compiling anstyle v1.0.1
   Compiling regex v1.9.1
   Compiling bstr v1.6.0
   Compiling walkdir v2.3.3
   Compiling anstream v0.3.2
   Compiling string_cache v0.8.7
   Compiling terminal_size v0.2.6
   Compiling mime_guess v2.0.4
   Compiling tendril v0.4.3
   Compiling phf v0.10.1
   Compiling inotify-sys v0.1.5
   Compiling num-traits v0.2.16
   Compiling mime v0.3.17
   Compiling clap_lex v0.5.0
   Compiling try-lock v0.2.4
   Compiling thiserror-impl v1.0.44
   Compiling tokio-macros v2.1.0
   Compiling futures-macro v0.3.28
   Compiling httpdate v1.0.2
   Compiling strsim v0.10.0
   Compiling byteorder v1.4.3
   Compiling clap_builder v4.3.19
   Compiling pin-project-internal v1.1.2
   Compiling want v0.3.1
   Compiling crossbeam-channel v0.5.8
   Compiling inotify v0.9.6
   Compiling filetime v0.2.21
   Compiling http-body v0.4.5
   Compiling pest v2.7.2
   Compiling tungstenite v0.18.0
   Compiling headers-core v0.2.0
   Compiling tower-service v0.3.2
   Compiling anyhow v1.0.72
   Compiling base64 v0.21.2
   Compiling pulldown-cmark v0.9.3
   Compiling rustls-pemfile v1.0.3
   Compiling headers v0.3.8
   Compiling pin-project v1.1.2
   Compiling notify v6.0.1
   Compiling clap v4.3.19
   Compiling pest_meta v2.7.2
   Compiling globset v0.4.12
   Compiling serde_urlencoded v0.7.1
   Compiling thread_local v1.1.7
   Compiling scoped-tls v1.0.1
   Compiling pest_generator v2.7.2
   Compiling fastrand v2.0.0
   Compiling humantime v2.1.0
   Compiling lazy_static v1.4.0
   Compiling iana-time-zone v0.1.57
   Compiling termcolor v1.2.0
   Compiling maplit v1.0.2
   Compiling chrono v0.4.26
   Compiling ignore v0.4.20
   Compiling env_logger v0.10.0
   Compiling tokio-util v0.7.8
   Compiling tokio-tungstenite v0.18.0
   Compiling html5ever v0.26.0
   Compiling tokio-stream v0.1.14
   Compiling tempfile v3.7.0
   Compiling pest_derive v2.7.2
   Compiling clap_complete v4.3.2
   Compiling h2 v0.3.20
   Compiling handlebars v4.3.7
   Compiling notify-debouncer-mini v0.3.0
   Compiling elasticlunr-rs v3.0.2
   Compiling opener v0.6.1
   Compiling toml v0.5.11
   Compiling shlex v1.1.0
   Compiling topological-sort v0.2.2
   Compiling ammonia v3.3.0
   Compiling hyper v0.14.27
   Compiling warp v0.3.5
   Compiling mdbook v0.4.32 (/tmp/下载/mdBook-master)
    Finished release [optimized] target(s) in 1m 55s
   Replacing /home/tim/.cargo/bin/mdbook
    Replaced package `mdbook v0.4.32` with `mdbook v0.4.32 (/tmp/下载/mdBook-master)` (executable `mdbook`)
❯ mdbook serve
2023-08-03 13:54:55 [ERROR] (mdbook::utils): Error: Couldn't open SUMMARY.md in "/tmp/下载/mdBook-master/src" directory
2023-08-03 13:54:55 [ERROR] (mdbook::utils):    Caused By: No such file or directory (os error 2)
❯ cargo install mdbook-svgbob
    Updating crates.io index
  Installing mdbook-svgbob v0.2.1
    Updating crates.io index
   Compiling proc-macro2 v1.0.66
   Compiling unicode-ident v1.0.11
   Compiling autocfg v1.1.0
   Compiling libc v0.2.147
   Compiling cfg-if v1.0.0
   Compiling log v0.4.19
   Compiling version_check v0.9.4
   Compiling once_cell v1.18.0
   Compiling syn v1.0.109
   Compiling serde v1.0.180
   Compiling memchr v2.5.0
   Compiling thiserror v1.0.44
   Compiling ppv-lite86 v0.2.17
   Compiling siphasher v0.3.10
   Compiling serde_derive v1.0.180
   Compiling bitflags v1.3.2
   Compiling typenum v1.16.0
   Compiling itoa v1.0.9
   Compiling phf_shared v0.10.0
   Compiling libm v0.2.7
   Compiling bytes v1.4.0
   Compiling regex-syntax v0.7.4
   Compiling fnv v1.0.7
   Compiling proc-macro-hack v0.5.20+deprecated
   Compiling futures-core v0.3.28
   Compiling pin-project-lite v0.2.10
   Compiling unicase v2.6.0
   Compiling generic-array v0.14.7
   Compiling num-traits v0.2.16
   Compiling slab v0.4.8
   Compiling rustix v0.38.6
   Compiling tokio v1.29.1
   Compiling quote v1.0.32
   Compiling aho-corasick v1.0.2
   Compiling http v0.2.9
   Compiling tinyvec_macros v0.1.1
   Compiling syn v2.0.28
   Compiling getrandom v0.2.10
   Compiling bitflags v2.3.3
   Compiling rand_core v0.6.4
   Compiling linux-raw-sys v0.4.5
   Compiling rand_chacha v0.3.1
   Compiling smallvec v1.11.0
   Compiling tinyvec v1.6.0
   Compiling rand v0.8.5
   Compiling mio v0.8.8
   Compiling num_cpus v1.16.0
   Compiling regex-automata v0.3.4
   Compiling socket2 v0.4.9
   Compiling phf_generator v0.10.0
   Compiling lock_api v0.4.10
   Compiling utf-8 v0.7.6
   Compiling io-lifetimes v1.0.11
   Compiling futures-task v0.3.28
   Compiling unicode-width v0.1.10
   Compiling futures-sink v0.3.28
   Compiling parking_lot_core v0.9.8
   Compiling percent-encoding v2.3.0
   Compiling form_urlencoded v1.2.0
   Compiling unicode-normalization v0.1.22
   Compiling block-buffer v0.10.4
   Compiling crypto-common v0.1.6
   Compiling scopeguard v1.2.0
   Compiling httparse v1.8.0
   Compiling new_debug_unreachable v1.0.4
   Compiling unicode-bidi v0.3.13
   Compiling rustix v0.37.23
   Compiling futures-util v0.3.28
   Compiling digest v0.10.7
   Compiling idna v0.4.0
   Compiling phf_codegen v0.10.0
   Compiling string_cache_codegen v0.5.2
   Compiling num-integer v0.1.45
   Compiling indexmap v1.9.3
   Compiling tracing-core v0.1.31
   Compiling pin-utils v0.1.0
   Compiling ryu v1.0.15
   Compiling cpufeatures v0.2.9
   Compiling utf8parse v0.2.1
   Compiling serde_json v1.0.104
   Compiling paste v1.0.14
   Compiling linux-raw-sys v0.3.8
   Compiling mac v0.1.1
   Compiling crossbeam-utils v0.8.16
   Compiling bytemuck v1.13.1
   Compiling is-terminal v0.4.9
   Compiling hashbrown v0.14.0
   Compiling equivalent v1.0.1
   Compiling ucd-trie v0.1.6
   Compiling safe_arch v0.7.1
   Compiling markup5ever v0.11.0
   Compiling tracing v0.1.37
   Compiling futf v0.1.5
   Compiling indexmap v2.0.0
   Compiling regex v1.9.1
   Compiling bstr v1.6.0
   Compiling anstyle-parse v0.2.1
   Compiling url v2.4.0
   Compiling sha1 v0.10.5
   Compiling parking_lot v0.12.1
   Compiling num-rational v0.4.1
   Compiling matrixmultiply v0.3.7
   Compiling anstyle v1.0.1
   Compiling colorchoice v1.0.0
   Compiling precomputed-hash v0.1.1
   Compiling doc-comment v0.3.3
   Compiling futures-channel v0.3.28
   Compiling winnow v0.5.3
   Compiling same-file v1.0.6
   Compiling toml_datetime v0.6.3
   Compiling anstyle-query v1.0.0
   Compiling base64 v0.13.1
   Compiling thiserror-impl v1.0.44
   Compiling tokio-macros v2.1.0
   Compiling futures-macro v0.3.28
   Compiling hashbrown v0.12.3
   Compiling anstream v0.3.2
   Compiling walkdir v2.3.3
   Compiling terminal_size v0.2.6
   Compiling string_cache v0.8.7
   Compiling mime_guess v2.0.4
   Compiling wide v0.7.11
   Compiling tendril v0.4.3
   Compiling toml_edit v0.19.14
   Compiling num-complex v0.4.3
   Compiling phf_macros v0.10.0
   Compiling pest v2.7.2
   Compiling html5ever v0.26.0
   Compiling approx v0.5.1
   Compiling inotify-sys v0.1.5
   Compiling mime v0.3.17
   Compiling rawpointer v0.2.1
   Compiling pulldown-cmark v0.9.3
   Compiling json v0.12.4
   Compiling httpdate v1.0.2
   Compiling byteorder v1.4.3
   Compiling clap_lex v0.5.0
   Compiling heck v0.4.1
   Compiling phf v0.10.1
   Compiling try-lock v0.2.4
   Compiling pest_meta v2.7.2
   Compiling strsim v0.10.0
   Compiling jss v0.5.1
   Compiling clap_derive v4.3.12
   Compiling clap_builder v4.3.19
^F   Compiling pest_generator v2.7.2
   Compiling want v0.3.1
   Compiling proc-macro-crate v1.3.1
   Compiling simba v0.7.3
   Compiling tungstenite v0.18.0
   Compiling tokio-util v0.7.8
   Compiling inotify v0.9.6
   Compiling crossbeam-channel v0.5.8
   Compiling nalgebra-macros v0.1.0
   Compiling pin-project-internal v1.1.2
   Compiling h2 v0.3.20
   Compiling serde_spanned v0.6.3
   Compiling getopts v0.2.21
   Compiling filetime v0.2.21
   Compiling http-body v0.4.5
   Compiling headers-core v0.2.0
   Compiling mt-dom v0.20.0
   Compiling either v1.9.0
   Compiling humantime v2.1.0
   Compiling termcolor v1.2.0
   Compiling lazy_static v1.4.0
   Compiling anyhow v1.0.72
   Compiling base64 v0.21.2
   Compiling cfg-if v0.1.10
   Compiling tower-service v0.3.2
   Compiling sauron-core v0.50.6
   Compiling rustls-pemfile v1.0.3
   Compiling headers v0.3.8
   Compiling pin-project v1.1.2
   Compiling clap v4.3.19
   Compiling notify v6.0.1
   Compiling pest_derive v2.7.2
   Compiling sauron-component-macro v0.50.6
   Compiling tokio-tungstenite v0.18.0
   Compiling tokio-stream v0.1.14
   Compiling num-derive v0.3.3
   Compiling globset v0.4.12
   Compiling serde_urlencoded v0.7.1
   Compiling thread_local v1.1.7
   Compiling downcast-rs v1.2.0
   Compiling iana-time-zone v0.1.57
   Compiling maplit v1.0.2
   Compiling fastrand v2.0.0
   Compiling rustc-hash v1.1.0
   Compiling arrayvec v0.7.4
   Compiling scoped-tls v1.0.1
   Compiling semver v1.0.18
   Compiling tempfile v3.7.0
   Compiling chrono v0.4.26
   Compiling ammonia v3.3.0
   Compiling ignore v0.4.20
   Compiling handlebars v4.3.7
   Compiling sauron v0.50.6
   Compiling hyper v0.14.27
   Compiling notify-debouncer-mini v0.3.0
   Compiling toml v0.7.6
   Compiling nalgebra v0.30.1
   Compiling clap_complete v4.3.2
   Compiling warp v0.3.5
   Compiling env_logger v0.10.0
   Compiling itertools v0.10.5
   Compiling elasticlunr-rs v3.0.2
   Compiling pom v3.3.0
   Compiling opener v0.6.1
   Compiling atty v0.2.14
   Compiling shlex v1.1.0
   Compiling topological-sort v0.2.2
   Compiling env_logger v0.9.3
   Compiling mdbook v0.4.32
   Compiling pulldown-cmark-to-cmark v10.0.4
   Compiling toml v0.5.11
   Compiling svg v0.12.1
   Compiling parry2d v0.8.0
   Compiling svgbob v0.6.7
   Compiling mdbook-svgbob v0.2.1
error[E0277]: the trait bound `Cfg: From<&toml::map::Map<std::string::String, toml::value::Value>>` is not satisfied
  --> /home/tim/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mdbook-svgbob-0.2.1/src/preprocessor.rs:58:42
   |
58 | ...                   .and_then(|map| map.try_into().map_err(|err| error!("{}", err)).ok())
   |                                           ^^^^^^^^ the trait `From<&toml::map::Map<std::string::String, toml::value::Value>>` is not implemented for `Cfg`
   |
   = note: required for `&toml::map::Map<std::string::String, toml::value::Value>` to implement `Into<Cfg>`
   = note: required for `Cfg` to implement `TryFrom<&toml::map::Map<std::string::String, toml::value::Value>>`
   = note: required for `&toml::map::Map<std::string::String, toml::value::Value>` to implement `TryInto<Cfg>`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `mdbook-svgbob` (bin "mdbook-svgbob") due to previous error
error: failed to compile `mdbook-svgbob v0.2.1`, intermediate artifacts can be found at `/tmp/cargo-installBfumk8`

@mgeisler mgeisler mentioned this issue Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: A bug, incorrect or unintended behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ehuss @mgeisler @ovo-Tim