bet

mod/da/types/sidecar.go

@@ -85,9 +85,6 @@ func (b *BlobSidecar) HasValidInclusionProof(
 	}
 
 	gIndex := kzgOffset + b.Index
-	// TODO:
-	// gindex = get_subtree_index(get_generalized_index(
-	// BeaconBlockBody, 'blob_kzg_commitments', blob_sidecar.index))
 
 	// Verify the inclusion proof.
 	return merkle.IsValidMerkleBranch(
@@ -96,7 +93,7 @@ func (b *BlobSidecar) HasValidInclusionProof(
 		//#nosec:G701 // safe.
 		uint8(
 			len(b.InclusionProof),
-		), // TODO: KZG_COMMITMENT_INCLUSION_PROOF_DEPTH
+		), // TODO: mak
 		gIndex,
 		b.BeaconBlockHeader.BodyRoot,
 	)

mod/primitives/math/u64.go

@@ -180,6 +180,16 @@ func (u U64) ILog2Ceil() uint8 {
 	return U64NumBits - uint8(bits.LeadingZeros64(uint64(u-1)))
 }
 
+// ILog2Floor returns the floor of the base 2 logarithm of the U64.
+func (u U64) ILog2Floor() uint8 {
+	// Log2(0) is undefined, should we panic?
+	if u == 0 {
+		return 0
+	}
+	//#nosec:G701 // we handle the case of u == 0 above, so this is safe.
+	return U64NumBits - uint8(bits.LeadingZeros64(uint64(u)))
+}
+
 // type U64Vector[U ~uint64] []U
 
 // func (v U64Vector[U]) HashTreeRoot() ([32]byte, error) {

mod/primitives/ssz/merkle/index.go

@@ -54,7 +54,7 @@ func NewGeneralizedIndex[RootT ~[32]byte](
 
 // Length returns the length of the generalized index.
 func (g GeneralizedIndex[RootT]) Length() uint64 {
-	return uint64(math.U64(g).ILog2Ceil())
+	return uint64(math.U64(g).ILog2Floor())
 }
 
 // IndexBit returns the bit at the specified position in a generalized index.