-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ssz): Implement basic generalized index stuff #837
Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
b.KzgCommitment.ToHashChunks()[0], | ||
kzgOffset+b.Index, | ||
func (b *BlobSidecar) HasValidInclusionProof( | ||
kzgOffset uint64, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is kzg offset just a magic number we pass in to point to the kzg branch? or how is it generated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good magic number, we don't know, need to figure out. There should be a way to derive it logically for an arbitrary Body.
No description provided.