updated electron

[oluoluoxenfree]

Summary

Updated electron to 4.0.1

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Issue

#274

[oluoluoxenfree]

I had an error locally which was the (ongoing?) --help indentation thing, but my errors on CI are completely different; anyone have any idea why that would be?

[ChrisBAshton]

Might want to update to 2.0.8 as per #274, rather than 4.0.1 which is two major versions ahead (so likely to have breaking API changes).

[ChrisBAshton]

Nice! I'll try and get it merged this week, unless another a11y maintainer can get there first :)

[andymsuk]

Version bumping is done as part of the release process as it needs to be done elsewhere too, so can you remove the version change in package.json and remove change in HISTORY?

[EmmaJP]

Version bumping is done as part of the release process as it needs to be done elsewhere too, so can you remove the version change in package.json and remove change in HISTORY?

Did the bbc-a11y version change get removed yet from this PR? Asking because I'm still seeing it in the 'Files changed'.

[oluoluoxenfree]

Not yet, I can do it this evening.

…

On Thu, Jan 31, 2019 at 11:57 AM EmmaJP ***@***.***> wrote: Version bumping is done as part of the release process as it needs to be done elsewhere too, so can you remove the version change in package.json and remove change in HISTORY? Did the bbc-a11y version change get removed yet from this PR? Asking because I'm still seeing it in the 'Files changed'. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#286 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC71Q2rmYjo8llq8cFmf6C06gyS9xKfiks5vItoZgaJpZM4ZzVRe> .

[oluoluoxenfree]

Is there anything else I need to do for this? @ChrisBAshton @andymsuk @EmmaJP

[andymsuk]

The update to the HISTORY file should be removed as it's done as part of the release process.

other than that, it's ready to merge and release - just need to find time to do it. Maybe @ChrisBAshton is more free than me?

[ChrisBAshton]

I'm not, unfortunately!

[andymsuk]

Hi @oluoluoxenfree
Apologies, I'd forgotten about this PR and now there's conflicts.
If you can resolve the conflicts, I can look to get this merged.

[oluoluoxenfree]

I think I might close this one and start a new PR with the updated master branch; there are a lot of changes in the package,.json

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.