Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron upgrade #274

Closed
EmmaJP opened this issue Oct 11, 2018 · 3 comments
Closed

Electron upgrade #274

EmmaJP opened this issue Oct 11, 2018 · 3 comments
Assignees
@oluoluoxenfree
Labels
effort-easy open-pr A PR is open for this issue urgent-prioritise Needs someone to do something asap

Comments

@EmmaJP
Copy link
Contributor

EmmaJP commented Oct 11, 2018

Github is alerting of possible security issues, and recommending a package-lock.json update. It suggests electron ~> 2.0.8.
@EmmaJP EmmaJP added effort-easy urgent-prioritise Needs someone to do something asap labels Dec 10, 2018
@EmmaJP
Copy link
Contributor Author

EmmaJP commented Dec 10, 2018

@oluoluoxenfree ... @andymsuk should be able to advise on what needs to change. As a collaborator, you should be able to branch and then submit a PR. The bbc-a11y version number will be changed as part of the release process.

@andymsuk
Copy link
Contributor

npm audit is your friend.

@oluoluoxenfree oluoluoxenfree mentioned this issue Jan 7, 2019
Closed
3 tasks
@oluoluoxenfree oluoluoxenfree added the open-pr A PR is open for this issue label Jan 7, 2019
@oluoluoxenfree oluoluoxenfree mentioned this issue May 17, 2019
Merged
3 tasks
@oluoluoxenfree
Copy link
Contributor

Closed as merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oluoluoxenfree oluoluoxenfree

Labels
effort-easy open-pr A PR is open for this issue urgent-prioritise Needs someone to do something asap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oluoluoxenfree @EmmaJP @andymsuk