Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snomed.reasoner): Add support for annotation properties in DelegateOntology as well (9.x) #1292

Merged

Conversation

apeteri
Copy link
Member

@apeteri apeteri commented May 8, 2024

Counterpart of #1291.

@apeteri apeteri requested review from cmark and nagyo May 8, 2024 09:57
@apeteri apeteri self-assigned this May 8, 2024
Copy link
Member

@nagyo nagyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 48.33%. Comparing base (3d89dac) to head (bb63a70).

Files Patch % Lines
...owl/snomed/reasoner/ontology/DelegateOntology.java 50.00% 16 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                9.x    #1292      +/-   ##
============================================
- Coverage     48.34%   48.33%   -0.01%     
- Complexity    13959    13964       +5     
============================================
  Files          1946     1946              
  Lines         95093    95132      +39     
  Branches      10987    10993       +6     
============================================
+ Hits          45969    45986      +17     
- Misses        46114    46133      +19     
- Partials       3010     3013       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cmark cmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥓

@cmark cmark merged commit a2b4c63 into 9.x May 8, 2024
4 of 5 checks passed
@cmark cmark deleted the issue/SO-6101-annotation-properties-in-delegateontology-9x branch May 8, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants