fix(snomed.reasoner): Add support for annotation properties in DelegateOntology as well

[apeteri]

No description provided.

[nagyo]

LGTM!

[cmark]

This looks okay to me, do we need any additional test cases for this?

[apeteri]

@AAAlinaaa added one here:

snow-owl/snomed/com.b2international.snowowl.snomed.core.rest.tests/src/com/b2international/snowowl/snomed/core/rest/classification/SnomedClassificationApiTest.java

Lines 587 to 622 in 297f06a

	@Test
	public void issue_SO_6106_testSubAnnotationPropertyOfAxiomClassification() throws Exception {
	String parentConceptId = createNewConcept(branchPath);
	String childConceptId = createNewConcept(branchPath, parentConceptId);
	createNewRefSetMember(branchPath, childConceptId, Concepts.REFSET_OWL_AXIOM, Map.of(
	SnomedRf2Headers.FIELD_OWL_EXPRESSION, "SubAnnotationPropertyOf(: " + childConceptId + " :" + parentConceptId + ")"));
	String classificationId = getClassificationJobId(beginClassification(branchPath));
	waitForClassificationJob(branchPath, classificationId)
	.statusCode(200)
	.body("status", equalTo(ClassificationStatus.COMPLETED.name()));
	InputStream inputStream = getRelationshipChanges(branchPath, classificationId)
	.statusCode(200)
	.extract()
	.asInputStream();
	Collection<RelationshipChange> changes = MAPPER.readValue(inputStream, RelationshipChanges.class).getItems();
	Multimap<String, RelationshipChange> changesBySource = Multimaps.index(changes, c -> c.getRelationship().getSourceId());
	Collection<RelationshipChange> parentRelationshipChanges = changesBySource.get(parentConceptId);
	Collection<RelationshipChange> childRelationshipChanges = changesBySource.get(childConceptId);
	for (RelationshipChange change : parentRelationshipChanges) {
	assertEquals(ChangeNature.NEW, change.getChangeNature());
	assertEquals(Concepts.IS_A, change.getRelationship().getTypeId());
	assertEquals(Concepts.ROOT_CONCEPT, change.getRelationship().getDestinationId());
	}
	for (RelationshipChange change : childRelationshipChanges) {
	assertEquals(ChangeNature.NEW, change.getChangeNature());
	assertEquals(Concepts.IS_A, change.getRelationship().getTypeId());
	assertEquals(parentConceptId, change.getRelationship().getDestinationId());
	}
	}

I think the child concept has a stated IS A relationship due to the test helper and this is why it passed earlier. I'll try to break it then see if the change fixes it 🔧

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 62.68%. Comparing base (4dcc43a) to head (31d524e).
Report is 19 commits behind head on 7.x.

❗ Current head 31d524e differs from pull request most recent head 0acc688. Consider uploading reports for the commit 0acc688 to get more accurate results

Files	Patch %	Lines
...owl/snomed/reasoner/ontology/DelegateOntology.java	50.00%	16 Missing and 4 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                7.x    #1291      +/-   ##
============================================
+ Coverage     62.62%   62.68%   +0.05%     
- Complexity    11506    11524      +18     
============================================
  Files          1612     1612              
  Lines         55173    55223      +50     
  Branches       5443     5451       +8     
============================================
+ Hits          34551    34615      +64     
+ Misses        18423    18404      -19     
- Partials       2199     2204       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cmark]

🥓