Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new smithy-modeled rules based endpoint resolution. #2214

Merged
merged 58 commits into from
Jul 31, 2023
Merged

Add a new smithy-modeled rules based endpoint resolution. #2214

merged 58 commits into from
Jul 31, 2023

Conversation

isaiahvita
Copy link
Contributor

This PR adds a significant feature to support smithy-modeled rules-based endpoint resolution which will supercede and deprecate existing endpoint resolution.

@isaiahvita isaiahvita requested a review from a team as a code owner July 27, 2023 15:57
aajtodd
aajtodd approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@aajtodd aajtodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix and ship

.github/workflows/codegen.yml Outdated Show resolved Hide resolved
service/accessanalyzer/api_client.go Outdated Show resolved Hide resolved
isaiahvita and others added 27 commits July 31, 2023 08:44
@isaiahvita
Add aws standard lib functions (#2057)
fe4c3b3
@isaiahvita
remove error collector for now (#2073)
c40b4dd
@isaiahvita
add partition generator, and run gofmt (#2076)
f4381d4
@isaiahvita
Add aws library functions for endpoint rules engine and fix partition…
f79579a 
… generation (#2110)
@isaiahvita
Add tests codegen and regen s3 (#2126)
0eb37e5
@isaiahvita
Add client config adapters (#2146)
72ed6c0
@isaiahvita
Add S3 Model Preprocessing for EP 2.0 (#2153)
98f1519 
Adds model preprocessing for S3 and S3 control due to EP 2.0 resolution handling certain bindings and host prefixes.

- `S3ControlHostPrefixAccountIdFilterIntegration`
- `S3HttpPathBucketFilterIntegration`
- `S3HostPrefixRequestRouteFilterIntegration`
@isaiahvita
Add BuiltIn generation (#2152)
50ceb26
@isaiahvita
Add endpoint-based auth scheme resolution (#2158)
7cb6d19
@isaiahvita
Remove httpLabel trait from Bucket members (#2173)
5a56b8a
@lucix-aws @isaiahvita
convert s3 handle_200_error_test into an actual unit test with a fake…
b44fbbf 
… HTTP client, instead of talking to an actual loopback server which was causing issues with dns resolution in ep2 (#2174)
@isaiahvita
Add functionality for non-SSL endpoints for backwards compatibility (#…
98caa35 
…2176)
@lucix-aws @isaiahvita
fix borked go mod files
f0fe836
@isaiahvita
Fix Properties Auth Scheme Path (#2177)
0839634 
Previously, properties were not being stored correctly, so the path for EP 2.0 Auth Scheme resolution was not being hit.

After the fix from aws/smithy-go#434 was merged, issues happened in the new code path.
@lucix-aws @isaiahvita
fix empty string signing name and region for sigv4 on ctx (#2178)
260ce31
@isaiahvita
Check S3 signer customization insensitively (#2179)
1229116 
* Check S3 signer customization insensitively
* Check EventBridge signer customization insensitively
@isaiahvita
Fix EP20 url encoding issues with S3 (#2181)
151def9
@lucix-aws @isaiahvita
serde buckets into immutable hostname endpts (#2182)
9d7de33
@lucix-aws @isaiahvita
adjust some expected errs
774213d
@lucix-aws @isaiahvita
remove incorrectly-applied {RequestRoute} filter
bd74619
@lucix-aws @isaiahvita
fix borked serializers from last commit
6921c80
@lucix-aws @isaiahvita
use httpbinding to escape instead
50e8ce8
@isaiahvita
Check hostname immutable in EndpointDisableHttps and make it service …
6c91a64 
…specific (#2184)
@isaiahvita
add back unintentionally deleted test cases (#2185)
4a484db
@lucix-aws @isaiahvita
fix s3 go.mods
85637ba
@lucix-aws @isaiahvita
update expected errs for (2)
50d9d41
@lucix-aws @isaiahvita
fix mrap error message asserts
679e5d9
isaiahvita and others added 27 commits July 31, 2023 08:44
@isaiahvita
Fix S3Control endpoint customization tests (#2195)
3fe6736
@isaiahvita
regen s3 and eventbridge; add context checker to eb; eb tests passing (…
1bbaab0 
…#2197)
@isaiahvita
Fix host prefix bug (#2200)
ecd96cc
@isaiahvita
Fix broken S3 tests (#2203)
906b316
@lucix-aws @isaiahvita
don't serde the bucket (#2204)
13216bc
@lucix-aws @isaiahvita
ADD noserde to bucket instead of swapping with httplabel to prevent s…
09b3a36 
…erializer body from generating
@lucix-aws @isaiahvita
mark EndpointResolverWithOptions deprecated
5c4a4d3
@isaiahvita
Added fallback behavior to custom v1 resolvers (#2206)
1a66c87
@isaiahvita
Make builtin resolver private (#2208)
6872543 
* make builtinresolver private

* regen s3
@isaiahvita
remove unnecessary line thats breaking full build (#2209)
5ce3521
@isaiahvita
fix no ruleset bug (#2210)
1dd1f49
@lucix-aws @isaiahvita
regen for ep2
e4bb6df
@lucix-aws @isaiahvita
suppress internal rulesfn lint
4fe37f7
@lucix-aws @isaiahvita
fix auth scheme test
b330936
@isaiahvita
remove middleware dependencies on resolveendpointv2 (#2211)
9bbecdd
@lucix-aws @isaiahvita
regen
8ac86b6
@isaiahvita
regen sdk (#2213)
3d0374d
@isaiahvita
add changelog file
0ffe660
@lucix-aws @isaiahvita
temp patch ci workflow to use upstream smithy-go
3b19a0d
@lucix-aws @isaiahvita
fix windows pathexp, point to ep20 smithygo for codegen
9920f71
@lucix-aws @isaiahvita
have lint use ep2 smithy-go, netip -> net for min go version
bbb3c26
@lucix-aws @isaiahvita
no source change: comment on ipv6 host id parse
87a6564
@isaiahvita
regen sdk
99b20d3
@isaiahvita
upgrade golint GH action
3afdb0f
@isaiahvita
remove ep20 hardcoding in GH action
b092577
@isaiahvita
fix deprecated comment
13394ca
@isaiahvita
fixed changelog file
e9c9311
@isaiahvita isaiahvita merged commit 26bf48f into main Jul 31, 2023
12 of 15 checks passed
@lucix-aws lucix-aws deleted the feat-ep20 branch May 6, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aajtodd aajtodd aajtodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaiahvita @aajtodd @lucix-aws