Add aws library functions for endpoint rules engine and fix partition generation #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
isaiahvita
commented
Apr 27, 2023
isaiahvita
commented
- endpoints2.0 needed aws library functions and they dont belong in the smithy-go repository.
- the partition function needed two different types for "partition config" this is because the default partition config should be guaranteed to always have values so those members needed to be Go value types. but the region overrides needed to be nullable.
isaiahvita
changed the title
aajtodd
approved these changes
May 1, 2023
| "af-south-1": { | ||
| Name: nil, | ||
| DNSSuffix: nil, | ||
| DualStackDNSSuffix: nil, | ||
| DnsSuffix: nil, |
There was a problem hiding this comment.
nit: nil is the default value, we could generate only the overrides and not have to explicitly set them. This would shorten the region maps and make the generated partitions slightly more readable as the overrides would be more clear.
aajtodd
approved these changes
May 5, 2023
isaiahvita
added a commit
that referenced
this pull request
May 12, 2023
isaiahvita
added a commit
that referenced
this pull request
May 17, 2023
isaiahvita
added a commit
that referenced
this pull request
May 17, 2023
isaiahvita
added a commit
to isaiahvita/aws-sdk-go-v2
that referenced
this pull request
Jul 25, 2023
isaiahvita
added a commit
that referenced
this pull request
Jul 25, 2023
isaiahvita
added a commit
that referenced
this pull request
Jul 27, 2023
isaiahvita
added a commit
that referenced
this pull request
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.