Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed doc typos and optimised PNGs #2000

Merged
merged 1 commit into from
Aug 16, 2017
Merged

Conversation

lcpz
Copy link
Contributor

@lcpz lcpz commented Aug 16, 2017

No description provided.

@@ -25,7 +25,7 @@ have not opened any programs. On the top right you see the time/date and a
symbol showing the current layout. You can also click on the symbol to change
the active layout.

One of awesome's big advantages over other tiling window managers is its good
One of awesome big advantages over other tiling window managers is its good
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was the old version of this wrong? It is awesome which has the big advantages, so 's, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not wrong, but traditional Saxon genitive is not used with things.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could write "One of the big advantages of Awesome" in case you want to get rid of the "'s".

btw: should be "Awesome" (capitalized) for consistency.

@@ -1,6 +1,6 @@
# Using Cairo and LGI

These days, Awesome's interface is mostly based on a library called LGI. It provides
These days, Awesome interface is mostly based on a library called LGI. It provides
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also: comma is not necessary - even the whole "These days, ".

@@ -75,7 +75,7 @@ of surfaces including:
* Monochrome image surfaces with transparency (`A8`) or without (`A1`)
* SVG vectorial surfaces
* Native (XCB) surfaces
* Framebuffers and other less interesting ones (from an Awesome's point of
* Framebuffers and other less interesting ones (from Awesome point of
view)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the removal of an, but I feel like 's should stay, no? (Same as above)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.7% when pulling 8f52a4a on copycat-killer:doc-fixes into cdaf0dd on awesomeWM:master.

@codecov
Copy link

codecov bot commented Aug 16, 2017

Codecov Report

Merging #2000 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2000      +/-   ##
==========================================
- Coverage   79.78%   79.73%   -0.06%     
==========================================
  Files         401      401              
  Lines       27303    27303              
  Branches      989      989              
==========================================
- Hits        21785    21771      -14     
- Misses       5084     5094      +10     
- Partials      434      438       +4
Flag Coverage Δ
#c_code 65.42% <ø> (-0.13%) ⬇️
#functionaltests 66.18% <ø> (-0.04%) ⬇️
#samples 67.62% <ø> (ø) ⬆️
#unittests 66.9% <ø> (ø) ⬆️
Impacted Files Coverage Δ
lib/awful/client/shape.lua 91.66% <0%> (-8.34%) ⬇️
xwindow.c 83.69% <0%> (-1.09%) ⬇️
objects/client.c 72.55% <0%> (-0.49%) ⬇️
spawn.c 64.75% <0%> (-0.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdaf0dd...8f52a4a. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 16, 2017

Codecov Report

Merging #2000 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2000      +/-   ##
==========================================
+ Coverage   79.83%   79.85%   +0.02%     
==========================================
  Files         401      401              
  Lines       27318    27318              
  Branches      991      991              
==========================================
+ Hits        21809    21816       +7     
+ Misses       5079     5070       -9     
- Partials      430      432       +2
Flag Coverage Δ
#c_code 65.71% <ø> (+0.04%) ⬆️
#functionaltests 66.29% <ø> (+0.02%) ⬆️
#samples 67.62% <ø> (ø) ⬆️
#unittests 66.9% <ø> (ø) ⬆️
Impacted Files Coverage Δ
event.c 57.29% <0%> (+0.64%) ⬆️
lib/awful/layout/suit/corner.lua 88.49% <0%> (+3.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4604ce7...1cd20b1. Read the comment docs.

@psychon
Copy link
Member

psychon commented Aug 16, 2017

Does "Optimise PNGs" mean "same content, but smaller file size"?

@lcpz
Copy link
Contributor Author

lcpz commented Aug 16, 2017

@psychon Yes, I used optipng -o7 %s recursively.

@lcpz lcpz force-pushed the doc-fixes branch 2 times, most recently from 95b4824 to ba140e2 Compare August 16, 2017 11:38
@lcpz
Copy link
Contributor Author

lcpz commented Aug 16, 2017

Fixed and rebased.

EDIT: How come coverage is decreased?

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ba140e2 on copycat-killer:doc-fixes into ** on awesomeWM:master**.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 84.674% when pulling ba140e2 on copycat-killer:doc-fixes into 4604ce7 on awesomeWM:master.

@blueyed
Copy link
Member

blueyed commented Aug 16, 2017

EDIT: How come coverage is decreased?

#1975

@@ -1,6 +1,6 @@
# Authors

## awesome - awesome window manager
## Awesome - Awesome window manager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2nd awesome should be lower case I think.

awesome step by step and finally come up with a working desktop, providing some
basic knowledge on how to configure awesome in the process. We will start with
the default `rc.lua` that comes with awesome, play around a little and try to
and don't have fancy hacking skills. We will explore the Awesome world of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Awesome/awesome

@@ -32,7 +32,7 @@ it only covers the minimal required changes to have a properly behaving config.

To test during the port, we recommend the `Xephyr` X11 server.

If Awesome4 **is not installed yet**, we recommand to install it in its own
If Awesome4 **is not installed yet**, we recommend to install it in its own
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Awesome4/Awesome v4/ ?!

@lcpz
Copy link
Contributor Author

lcpz commented Aug 16, 2017

Requested changes done.

@psychon psychon requested a review from blueyed August 16, 2017 15:05
@blueyed blueyed merged commit 4fc3108 into awesomeWM:master Aug 16, 2017
@blueyed
Copy link
Member

blueyed commented Aug 16, 2017

Thank you!

@lcpz lcpz deleted the doc-fixes branch August 16, 2017 18:26
petoju pushed a commit to petoju/awesome that referenced this pull request Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants