-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed doc typos and optimised PNGs #2000
Conversation
docs/07-my-first-awesome.md
Outdated
@@ -25,7 +25,7 @@ have not opened any programs. On the top right you see the time/date and a | |||
symbol showing the current layout. You can also click on the symbol to change | |||
the active layout. | |||
|
|||
One of awesome's big advantages over other tiling window managers is its good | |||
One of awesome big advantages over other tiling window managers is its good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was the old version of this wrong? It is awesome which has the big advantages, so 's
, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not wrong, but traditional Saxon genitive is not used with things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could write "One of the big advantages of Awesome" in case you want to get rid of the "'s".
btw: should be "Awesome" (capitalized) for consistency.
docs/16-using-cairo.md
Outdated
@@ -1,6 +1,6 @@ | |||
# Using Cairo and LGI | |||
|
|||
These days, Awesome's interface is mostly based on a library called LGI. It provides | |||
These days, Awesome interface is mostly based on a library called LGI. It provides |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also: comma is not necessary - even the whole "These days, ".
docs/16-using-cairo.md
Outdated
@@ -75,7 +75,7 @@ of surfaces including: | |||
* Monochrome image surfaces with transparency (`A8`) or without (`A1`) | |||
* SVG vectorial surfaces | |||
* Native (XCB) surfaces | |||
* Framebuffers and other less interesting ones (from an Awesome's point of | |||
* Framebuffers and other less interesting ones (from Awesome point of | |||
view) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the removal of an
, but I feel like 's
should stay, no? (Same as above)
Codecov Report
@@ Coverage Diff @@
## master #2000 +/- ##
==========================================
- Coverage 79.78% 79.73% -0.06%
==========================================
Files 401 401
Lines 27303 27303
Branches 989 989
==========================================
- Hits 21785 21771 -14
- Misses 5084 5094 +10
- Partials 434 438 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #2000 +/- ##
==========================================
+ Coverage 79.83% 79.85% +0.02%
==========================================
Files 401 401
Lines 27318 27318
Branches 991 991
==========================================
+ Hits 21809 21816 +7
+ Misses 5079 5070 -9
- Partials 430 432 +2
Continue to review full report at Codecov.
|
Does "Optimise PNGs" mean "same content, but smaller file size"? |
@psychon Yes, I used |
95b4824
to
ba140e2
Compare
Fixed and rebased. EDIT: How come coverage is decreased? |
Changes Unknown when pulling ba140e2 on copycat-killer:doc-fixes into ** on awesomeWM:master**. |
|
docs/00-authors.md
Outdated
@@ -1,6 +1,6 @@ | |||
# Authors | |||
|
|||
## awesome - awesome window manager | |||
## Awesome - Awesome window manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2nd awesome
should be lower case I think.
docs/07-my-first-awesome.md
Outdated
awesome step by step and finally come up with a working desktop, providing some | ||
basic knowledge on how to configure awesome in the process. We will start with | ||
the default `rc.lua` that comes with awesome, play around a little and try to | ||
and don't have fancy hacking skills. We will explore the Awesome world of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Awesome/awesome
docs/17-porting-tips.md
Outdated
@@ -32,7 +32,7 @@ it only covers the minimal required changes to have a properly behaving config. | |||
|
|||
To test during the port, we recommend the `Xephyr` X11 server. | |||
|
|||
If Awesome4 **is not installed yet**, we recommand to install it in its own | |||
If Awesome4 **is not installed yet**, we recommend to install it in its own |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Awesome4/Awesome v4/ ?!
Requested changes done. |
Thank you! |
No description provided.