Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add making most of markdown to tutorial page #4376

Merged
merged 4 commits into from
Dec 11, 2023
Merged

docs: add making most of markdown to tutorial page #4376

merged 4 commits into from
Dec 11, 2023

Conversation

sdiazlor
Copy link
Contributor

@sdiazlor sdiazlor commented Dec 5, 2023

Description

Update grid to add making most of markdown tutorial and move it with the other Feedback tutorials

Closes #4370

Type of change

(Remember to title the PR according to the type of change)

  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes.)

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@sdiazlor sdiazlor linked an issue Dec 5, 2023 that may be closed by this pull request
[DOCS] add making most of markdown to tutorial page #4370
Closed
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. area: architecture Indicates that an issue or pull request is related to the architecture type: documentation Improvements or additions to documentation labels Dec 5, 2023
@sdiazlor sdiazlor changed the base branch from develop to main December 5, 2023 11:13
@sdiazlor sdiazlor self-assigned this Dec 5, 2023
davidberenstein1957
davidberenstein1957 reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text can maybe be a bit more explicit and also mention video, audio etc. Also, the references from the other places of the docs should redirect to the new file.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 7, 2023
@davidberenstein1957
Copy link
Member

@sdiazlor can you resolve this merge conflict?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 11, 2023
@davidberenstein1957 davidberenstein1957 merged commit 185e4a7 into main Dec 11, 2023
17 checks passed
@davidberenstein1957 davidberenstein1957 deleted the docs/4370-docs-add-making-most-of-markdown-to-tutorial-page branch December 11, 2023 11:48
leiyre pushed a commit that referenced this pull request Dec 12, 2023
Merge branch 'develop' into feature/prepare-bulk-annotation
ef50946 
* develop: (21 commits)
  ✨ Fix error handling in axios plugin for 401 (#4362)
  docs: Change `telemetry` section in tutorials to directly executable cells (#4399)
  docs: add faq files (#4363)
  fix: pinning `pytest-asyncio` to version `0.21.1` to avoid problems running unit tests on GitHub workflows (#4395)
  docs: add making most of markdown to tutorial page (#4376)
  Fixing typo in Fine Tuning LLMs Practical Guides (#4392)
  Token Classification epochs parameter trainer changed (#4393)
  docs: align practical guidescreate datasethtml with end2end examples structure (#4375)
  docs: hugging face space url (#4379)
  docs: extend using proxy section (#4368)
  chore: update dev version
  chore: update CHANGELOG.md before release v1.20.0 (#4357)
  docs: temporal update to indicate persistent storage (#4355)
  docs: add suggestions and responses filters and sorting (#4345)
  docs: add end2end example on creating a basic text-classification dataset (#4208)
  Fix/responses suggestions filter fine tune (#4356)
  Fix/responses suggestions filter fine tune (#4356)
  fix: Accept draft responses on dataset records creation (#4354)
  Feature/responses operator (#4352)
  Feature/responses operator (#4352)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidberenstein1957 davidberenstein1957 davidberenstein1957 approved these changes

Assignees

@sdiazlor sdiazlor

Labels
area: architecture Indicates that an issue or pull request is related to the architecture lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS] add making most of markdown to tutorial page
2 participants
@sdiazlor @davidberenstein1957