Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Accept draft responses on dataset records creation #4354

Merged
merged 2 commits into from
Nov 29, 2023
Merged

fix: Accept draft responses on dataset records creation #4354

merged 2 commits into from
Nov 29, 2023

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Nov 29, 2023 •
edited
Loading

Description

This PR fixed the error when passing draft responses to the create records endpoint.

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

  • Tested locally

Checklist

  • I followed the style guidelines of this project
  • I did a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. area: api Indicates that an issue or pull request is related to the Fast API server or REST endpoints language: python Pull requests or issues that update Python code team: backend Indicates that the issue or pull request is owned by the backend team type: bug Indicates an unexpected problem or unintended behavior labels Nov 29, 2023
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 29, 2023
@github-actions GitHub Actions
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4354-ki24f765kq-no.a.run.app

@frascuchon frascuchon merged commit 933f96a into releases/1.20.0 Nov 29, 2023
18 of 19 checks passed
@frascuchon frascuchon deleted the bugfixes/allow-create-records-with-draft-responses branch November 29, 2023 15:30
leiyre pushed a commit that referenced this pull request Dec 5, 2023
Merge branch 'develop' into feature/bulk-annotation
3fb884f 
* develop: (41 commits)
  chore: update dev version
  chore: update CHANGELOG.md before release v1.20.0 (#4357)
  docs: temporal update to indicate persistent storage (#4355)
  docs: add suggestions and responses filters and sorting (#4345)
  docs: add end2end example on creating a basic text-classification dataset (#4208)
  Fix/responses suggestions filter fine tune (#4356)
  Fix/responses suggestions filter fine tune (#4356)
  fix: Accept draft responses on dataset records creation (#4354)
  Feature/responses operator (#4352)
  Feature/responses operator (#4352)
  chore: increase dev version release to 1.21.0
  chore: remove dev suffix for release branch
  fix: responses and suggestions filter QA (#4337)
  feat: delete suggestion from record on search engine (#4336)
  feat: update suggestion from record on search engine (#4339)
  bug: fix bug and update test (#4341)
  fix: preserve `TextClassificationSettings.label_schema` order (#4332)
  Update issue templates
  feat: 🚀 support for filtering and sorting by responses and suggestions (#4160)
  fix: handling errors for non-existing endpoints (#4325)
  ...

# Conflicts:
#	frontend/v1/domain/entities/question/Question.ts
#	frontend/v1/domain/entities/record/Record.ts
leiyre pushed a commit that referenced this pull request Dec 12, 2023
Merge branch 'develop' into feature/prepare-bulk-annotation
ef50946 
* develop: (21 commits)
  ✨ Fix error handling in axios plugin for 401 (#4362)
  docs: Change `telemetry` section in tutorials to directly executable cells (#4399)
  docs: add faq files (#4363)
  fix: pinning `pytest-asyncio` to version `0.21.1` to avoid problems running unit tests on GitHub workflows (#4395)
  docs: add making most of markdown to tutorial page (#4376)
  Fixing typo in Fine Tuning LLMs Practical Guides (#4392)
  Token Classification epochs parameter trainer changed (#4393)
  docs: align practical guidescreate datasethtml with end2end examples structure (#4375)
  docs: hugging face space url (#4379)
  docs: extend using proxy section (#4368)
  chore: update dev version
  chore: update CHANGELOG.md before release v1.20.0 (#4357)
  docs: temporal update to indicate persistent storage (#4355)
  docs: add suggestions and responses filters and sorting (#4345)
  docs: add end2end example on creating a basic text-classification dataset (#4208)
  Fix/responses suggestions filter fine tune (#4356)
  Fix/responses suggestions filter fine tune (#4356)
  fix: Accept draft responses on dataset records creation (#4354)
  Feature/responses operator (#4352)
  Feature/responses operator (#4352)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfcalvo jfcalvo jfcalvo approved these changes

@gabrielmbmb gabrielmbmb gabrielmbmb approved these changes

Assignees
No one assigned
Labels
area: api Indicates that an issue or pull request is related to the Fast API server or REST endpoints language: python Pull requests or issues that update Python code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. team: backend Indicates that the issue or pull request is owned by the backend team type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frascuchon @jfcalvo @gabrielmbmb