add check compressor's byte size when finish compress #277

famosss · 2017-09-26T01:58:06Z

org.apache.hadoop.io.compress.BlockCompressorStream#finish is a public function,so other apps can call the method directly,such as flume,but when compressor.getBytesRead() == 0 then it will write a null data,and then the data after the null data will not be read as they lost. So,please add the check in the method.
Thank you.

hadoop-yetus · 2019-07-19T19:17:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	39	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	1038	trunk passed
+1	compile	1035	trunk passed
+1	checkstyle	39	trunk passed
+1	mvnsite	74	trunk passed
+1	shadedclient	734	branch has no errors when building and testing our client artifacts.
+1	javadoc	58	trunk passed
0	spotbugs	115	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	112	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	49	the patch passed
+1	compile	1016	the patch passed
+1	javac	1016	the patch passed
+1	checkstyle	39	the patch passed
+1	mvnsite	72	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	623	patch has no errors when building and testing our client artifacts.
+1	javadoc	60	the patch passed
+1	findbugs	125	the patch passed
		_ Other Tests _
-1	unit	482	hadoop-common in the patch failed.
+1	asflicense	43	The patch does not generate ASF License warnings.
		5713

Reason	Tests
Failed junit tests	hadoop.io.compress.TestCompressorDecompressor
	hadoop.io.compress.lz4.TestLz4CompressorDecompressor
	hadoop.io.compress.TestBlockDecompressorStream
	hadoop.ipc.TestIPC
	hadoop.io.compress.snappy.TestSnappyCompressorDecompressor
	hadoop.ha.TestActiveStandbyElectorRealZK
	hadoop.io.compress.zlib.TestZlibCompressorDecompressor

Subsystem	Report/Notes
Docker	Client=18.09.8 Server=18.09.8 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-277/1/artifact/out/Dockerfile
GITHUB PR	#277
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 8257388284a5 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `7f1b76c`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/1/testReport/
Max. process+thread count	1463 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/1/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-07-26T20:21:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	88	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	1211	trunk passed
+1	compile	1213	trunk passed
+1	checkstyle	47	trunk passed
+1	mvnsite	91	trunk passed
+1	shadedclient	929	branch has no errors when building and testing our client artifacts.
+1	javadoc	69	trunk passed
0	spotbugs	147	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	143	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	55	the patch passed
+1	compile	1056	the patch passed
+1	javac	1056	the patch passed
+1	checkstyle	46	the patch passed
+1	mvnsite	84	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	750	patch has no errors when building and testing our client artifacts.
+1	javadoc	74	the patch passed
+1	findbugs	160	the patch passed
		_ Other Tests _
-1	unit	578	hadoop-common in the patch failed.
+1	asflicense	61	The patch does not generate ASF License warnings.
		6717

Reason	Tests
Failed junit tests	hadoop.io.compress.TestCompressorDecompressor
	hadoop.io.compress.snappy.TestSnappyCompressorDecompressor
	hadoop.io.compress.zlib.TestZlibCompressorDecompressor
	hadoop.io.compress.lz4.TestLz4CompressorDecompressor
	hadoop.io.compress.TestBlockDecompressorStream

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-277/2/artifact/out/Dockerfile
GITHUB PR	#277
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 7ca22ace990f 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `62efb63`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/2/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/2/testReport/
Max. process+thread count	1335 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/2/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-02T06:34:25Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	42	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	1090	trunk passed
+1	compile	1117	trunk passed
+1	checkstyle	37	trunk passed
+1	mvnsite	76	trunk passed
+1	shadedclient	758	branch has no errors when building and testing our client artifacts.
+1	javadoc	58	trunk passed
0	spotbugs	116	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	113	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	46	the patch passed
+1	compile	1028	the patch passed
+1	javac	1028	the patch passed
+1	checkstyle	39	the patch passed
+1	mvnsite	72	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	645	patch has no errors when building and testing our client artifacts.
+1	javadoc	60	the patch passed
+1	findbugs	127	the patch passed
		_ Other Tests _
-1	unit	490	hadoop-common in the patch failed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		5898

Reason	Tests
Failed junit tests	hadoop.io.compress.TestCompressorDecompressor
	hadoop.io.compress.lz4.TestLz4CompressorDecompressor
	hadoop.io.compress.TestBlockDecompressorStream
	hadoop.io.compress.snappy.TestSnappyCompressorDecompressor
	hadoop.io.compress.zlib.TestZlibCompressorDecompressor

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-277/3/artifact/out/Dockerfile
GITHUB PR	#277
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux d71e6c7e227e 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `e872ceb`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/3/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/3/testReport/
Max. process+thread count	1463 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/3/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-08T08:02:40Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	43	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	1031	trunk passed
+1	compile	1097	trunk passed
+1	checkstyle	40	trunk passed
+1	mvnsite	71	trunk passed
+1	shadedclient	741	branch has no errors when building and testing our client artifacts.
+1	javadoc	60	trunk passed
0	spotbugs	113	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	111	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	45	the patch passed
+1	compile	1213	the patch passed
+1	javac	1213	the patch passed
+1	checkstyle	38	the patch passed
+1	mvnsite	64	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	596	patch has no errors when building and testing our client artifacts.
+1	javadoc	59	the patch passed
+1	findbugs	131	the patch passed
		_ Other Tests _
-1	unit	520	hadoop-common in the patch failed.
+1	asflicense	41	The patch does not generate ASF License warnings.
		5955

Reason	Tests
Failed junit tests	hadoop.io.compress.snappy.TestSnappyCompressorDecompressor
	hadoop.io.compress.lz4.TestLz4CompressorDecompressor
	hadoop.ha.TestZKFailoverController
	hadoop.io.compress.TestBlockDecompressorStream
	hadoop.io.compress.zlib.TestZlibCompressorDecompressor
	hadoop.io.compress.TestCompressorDecompressor

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-277/4/artifact/out/Dockerfile
GITHUB PR	#277
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 6e3ba3f6e42d 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `00b5a27`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/4/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/4/testReport/
Max. process+thread count	1425 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/4/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-16T22:06:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	91	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	1201	trunk passed
+1	compile	1110	trunk passed
+1	checkstyle	40	trunk passed
+1	mvnsite	73	trunk passed
+1	shadedclient	853	branch has no errors when building and testing our client artifacts.
+1	javadoc	68	trunk passed
0	spotbugs	154	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	151	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	56	the patch passed
+1	compile	1062	the patch passed
+1	javac	1062	the patch passed
+1	checkstyle	40	the patch passed
+1	mvnsite	69	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	748	patch has no errors when building and testing our client artifacts.
+1	javadoc	64	the patch passed
+1	findbugs	154	the patch passed
		_ Other Tests _
-1	unit	557	hadoop-common in the patch failed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		6486

Reason	Tests
Failed junit tests	hadoop.io.compress.lz4.TestLz4CompressorDecompressor
	hadoop.io.compress.snappy.TestSnappyCompressorDecompressor
	hadoop.io.compress.TestCompressorDecompressor
	hadoop.io.compress.TestBlockDecompressorStream
	hadoop.io.compress.zlib.TestZlibCompressorDecompressor

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-277/5/artifact/out/Dockerfile
GITHUB PR	#277
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux eb74f0f64b5a 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `e356e4f`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/5/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/5/testReport/
Max. process+thread count	1348 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/5/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-20T19:29:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	38	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	1071	trunk passed
+1	compile	1018	trunk passed
+1	checkstyle	35	trunk passed
+1	mvnsite	68	trunk passed
+1	shadedclient	734	branch has no errors when building and testing our client artifacts.
+1	javadoc	54	trunk passed
0	spotbugs	109	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	108	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	45	the patch passed
+1	compile	1006	the patch passed
+1	javac	1006	the patch passed
+1	checkstyle	40	the patch passed
+1	mvnsite	66	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	644	patch has no errors when building and testing our client artifacts.
+1	javadoc	54	the patch passed
+1	findbugs	120	the patch passed
		_ Other Tests _
-1	unit	494	hadoop-common in the patch failed.
+1	asflicense	44	The patch does not generate ASF License warnings.
		5701

Reason	Tests
Failed junit tests	hadoop.io.compress.snappy.TestSnappyCompressorDecompressor
	hadoop.io.compress.TestBlockDecompressorStream
	hadoop.io.compress.zlib.TestZlibCompressorDecompressor
	hadoop.io.compress.lz4.TestLz4CompressorDecompressor
	hadoop.io.compress.TestCompressorDecompressor

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-277/6/artifact/out/Dockerfile
GITHUB PR	#277
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 6cfd7362a069 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `4cb22cd`
Default Java	1.8.0_222
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/6/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/6/testReport/
Max. process+thread count	1447 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/6/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-22T18:50:29Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	40	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	1068	trunk passed
+1	compile	1024	trunk passed
+1	checkstyle	34	trunk passed
+1	mvnsite	65	trunk passed
+1	shadedclient	723	branch has no errors when building and testing our client artifacts.
+1	javadoc	56	trunk passed
0	spotbugs	112	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	109	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	43	the patch passed
+1	compile	1032	the patch passed
+1	javac	1032	the patch passed
+1	checkstyle	34	the patch passed
+1	mvnsite	62	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	618	patch has no errors when building and testing our client artifacts.
+1	javadoc	56	the patch passed
+1	findbugs	117	the patch passed
		_ Other Tests _
-1	unit	515	hadoop-common in the patch failed.
+1	asflicense	37	The patch does not generate ASF License warnings.
		5699

Reason	Tests
Failed junit tests	hadoop.io.compress.lz4.TestLz4CompressorDecompressor
	hadoop.io.compress.snappy.TestSnappyCompressorDecompressor
	hadoop.io.compress.TestCompressorDecompressor
	hadoop.util.TestDiskChecker
	hadoop.io.compress.TestBlockDecompressorStream
	hadoop.io.compress.zlib.TestZlibCompressorDecompressor

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-277/7/artifact/out/Dockerfile
GITHUB PR	#277
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 109f0baec537 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `63c295e`
Default Java	1.8.0_222
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/7/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/7/testReport/
Max. process+thread count	1346 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/7/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2019-08-27T16:43:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	91	Docker mode activated.
		_ Prechecks _
+1	dupname	0	No case conflicting files found.
+1	@author	0	The patch does not contain any @author tags.
-1	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1	mvninstall	1246	trunk passed
+1	compile	1124	trunk passed
+1	checkstyle	40	trunk passed
+1	mvnsite	77	trunk passed
+1	shadedclient	847	branch has no errors when building and testing our client artifacts.
+1	javadoc	63	trunk passed
0	spotbugs	130	Used deprecated FindBugs config; considering switching to SpotBugs.
+1	findbugs	128	trunk passed
		_ Patch Compile Tests _
+1	mvninstall	49	the patch passed
+1	compile	1129	the patch passed
+1	javac	1129	the patch passed
+1	checkstyle	59	the patch passed
+1	mvnsite	96	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedclient	888	patch has no errors when building and testing our client artifacts.
+1	javadoc	82	the patch passed
+1	findbugs	157	the patch passed
		_ Other Tests _
-1	unit	627	hadoop-common in the patch failed.
+1	asflicense	62	The patch does not generate ASF License warnings.
		6863

Reason	Tests
Failed junit tests	hadoop.io.compress.lz4.TestLz4CompressorDecompressor
	hadoop.io.compress.snappy.TestSnappyCompressorDecompressor
	hadoop.io.compress.TestCompressorDecompressor
	hadoop.io.compress.TestBlockDecompressorStream
	hadoop.io.compress.zlib.TestZlibCompressorDecompressor

Subsystem	Report/Notes
Docker	Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-277/8/artifact/out/Dockerfile
GITHUB PR	#277
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux c2b31404b30b 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `3329257`
Default Java	1.8.0_212
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/8/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/8/testReport/
Max. process+thread count	1348 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-277/8/console
versions	git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by	Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

This patch contains the following changes: 1. Refactor watermark and end-of-stream logic. The aggregation/handling has been moved from WatermarkManager/EndOfStreamManager to be inline inside OperatorImpl. This is for keeping the logic in one place. 2. Now subclass of OperatorImpl will override handleWatermark() to do its specific handling, such as fire trigger. 3. Add emitWatermark() in OperatorImpl so subclass can call it to emit watermark upon receiving a message or watermark. Author: Xinyu Liu <[email protected]> Author: Xinyu Liu <[email protected]> Reviewers: Yi Pan <[email protected]> Closes apache#277 from xinyuiscool/SAMZA-1386

hadoop-yetus · 2022-01-31T22:39:42Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 56s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	36m 8s		trunk passed
+1 💚	compile	25m 57s		trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	compile	22m 18s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 58s		trunk passed
+1 💚	mvnsite	1m 42s		trunk passed
+1 💚	javadoc	1m 8s		trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 40s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	2m 34s		trunk passed
+1 💚	shadedclient	25m 48s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	1m 0s		the patch passed
+1 💚	compile	23m 23s		the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javac	23m 23s		the patch passed
+1 💚	compile	20m 31s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	20m 31s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 58s		the patch passed
+1 💚	mvnsite	1m 35s		the patch passed
+1 💚	javadoc	1m 5s		the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04
+1 💚	javadoc	1m 39s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	2m 39s		the patch passed
+1 💚	shadedclient	25m 27s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	17m 27s	/patch-unit-hadoop-common-project_hadoop-common.txt	hadoop-common in the patch passed.
+1 💚	asflicense	0m 48s		The patch does not generate ASF License warnings.
		215m 5s

Reason	Tests
Failed junit tests	hadoop.io.compress.TestCompressorDecompressor
	hadoop.io.compress.zlib.TestZlibCompressorDecompressor
	hadoop.io.compress.lz4.TestLz4CompressorDecompressor
	hadoop.io.compress.TestBlockDecompressorStream
	hadoop.io.compress.snappy.TestSnappyCompressorDecompressor

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-277/1/artifact/out/Dockerfile
GITHUB PR	#277
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname	Linux a80b332b7674 4.15.0-153-generic #160-Ubuntu SMP Thu Jul 29 06:54:29 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `64ff30f`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-277/1/testReport/
Max. process+thread count	2667 (vs. ulimit of 5500)
modules	C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-277/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

add check compressor's byte size when finish compress

64ff30f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add check compressor's byte size when finish compress #277

add check compressor's byte size when finish compress #277

famosss commented Sep 26, 2017

hadoop-yetus commented Jul 19, 2019

hadoop-yetus commented Jul 26, 2019

hadoop-yetus commented Aug 2, 2019

hadoop-yetus commented Aug 8, 2019

hadoop-yetus commented Aug 16, 2019

hadoop-yetus commented Aug 20, 2019

hadoop-yetus commented Aug 22, 2019

hadoop-yetus commented Aug 27, 2019

hadoop-yetus commented Jan 31, 2022

add check compressor's byte size when finish compress #277

Are you sure you want to change the base?

add check compressor's byte size when finish compress #277

Conversation

famosss commented Sep 26, 2017

hadoop-yetus commented Jul 19, 2019

hadoop-yetus commented Jul 26, 2019

hadoop-yetus commented Aug 2, 2019

hadoop-yetus commented Aug 8, 2019

hadoop-yetus commented Aug 16, 2019

hadoop-yetus commented Aug 20, 2019

hadoop-yetus commented Aug 22, 2019

hadoop-yetus commented Aug 27, 2019

hadoop-yetus commented Jan 31, 2022