Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github URL in test repos to refer to eclipse-openj9 #2551

Closed
llxia opened this issue Apr 29, 2021 · 10 comments · Fixed by adoptium/openj9-systemtest#130 or #2556
Closed

Update github URL in test repos to refer to eclipse-openj9 #2551

llxia opened this issue Apr 29, 2021 · 10 comments · Fixed by adoptium/openj9-systemtest#130 or #2556
Assignees
Labels
Milestone

Comments

@llxia
Copy link
Contributor

llxia commented Apr 29, 2021

The openj9 repos have been moved from https://github.com/eclipse to https://github.com/eclipse-openj9, we should update any github URLs to refer to eclipse-openj9.

https://github.com/eclipse-openj9/openj9
https://github.com/eclipse-openj9/openj9-systemtest

PR for updating openj9 repo: eclipse-openj9/openj9#12592

@SAY-droid427
Copy link
Contributor

Hey @llxia May I work on this issue?

@SAY-droid427
Copy link
Contributor

@llxia @smlambert I have made a PR for the issue. Please review it. Thank you!

@llxia
Copy link
Contributor Author

llxia commented Apr 30, 2021

Thanks @SAY-droid427 . Please also update references in https://github.com/adoptium/aqa-tests

@Mesbah-Alam
Copy link
Contributor

Just an FYI : PRs related to this issue will potentially create merge conflict with PRs created for adoptium/aqa-systemtest#424. Those would have to be manually resolved.

@SAY-droid427
Copy link
Contributor

SAY-droid427 commented Apr 30, 2021

@lxia Any copyright updates I need to make for the https://github.com/adoptium/aqa-tests?

@llxia
Copy link
Contributor Author

llxia commented Apr 30, 2021

Any copyright updates I need to make for the https://github.com/adoptium/aqa-tests?

I do not think you need to update the copyright in aqa-tests repo

@LongyuZhang
Copy link
Contributor

Repo https://github.com/adoptium/aqa-test-tools is also affected by this move, e.g. PossibleIssues.jsx has eclipse/openj9.

@smlambert
Copy link
Contributor

Lan is correct, any of the test repositories under the adoptium github organization do not require the same handling of copyright as those under the eclipse-openj9 organization.

and regarding #2551 (comment), we should create issues in each of the test repos for checking and updating references to AdoptOpenJDK now that we have moved all the test repositories out of that github organization. And those changes will likely have to be coordinated, as example, this PR in the run-aqa will fail: adoptium/run-aqa#82 unless we also update the get.sh script in this aqa-tests repository.

@SAY-droid427
Copy link
Contributor

@LongyuZhang Should I make a PR for making the changes in the https://github.com/adoptium/aqa-test-tools repo ?

@LongyuZhang
Copy link
Contributor

@LongyuZhang Should I make a PR for making the changes in the https://github.com/adoptium/aqa-test-tools repo ?

Hi @SAY-droid427 I have created issue for it in aqa-test-tools repo, feel free to wok on it if you are interested. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment