Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messaging #32

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Improve error messaging #32

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9be01e1
Improve error messaging
robotdana Aug 30, 2022
4c7c446
Print the json to a file
robotdana Oct 21, 2022
57c7782
Add lighthouse results artefact
robotdana Oct 21, 2022
8399f68
Do the one performance suggestion
robotdana Oct 21, 2022
74ea6a4
test: use a block when checking exception to ensure the full message …
G-Rath Aug 27, 2023
ee98817
test: fix example spec
G-Rath Aug 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: fix example spec
  • Loading branch information
@G-Rath
G-Rath committed Aug 27, 2023
commit ee98817af4fa6d2ed3e4c390006959d0dacaf24b
2 changes: 1 addition & 1 deletion spec/lighthouse/matchers/rspec_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
{
'message' => <<~FAIL
expected #{example_url} to pass Lighthouse #{audit} audit
with a minimum score of 100, but only scored #{score}.
with a minimum score of 100, but only scored #{score.to_f}.

Full report:
#{Lighthouse::Matchers.results_directory}/f60a563794dfeedda6feeab0ec4a011c6bd74ff9.json
Expand Down