Improve error messaging #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is actually a duplicate of #26 (which itself is sort of a duplicate of #13) - the blocker has been getting the time to sort out deployments because I believe only @joshmcarthur has access to that. I'll book some time with him when he's back to get this closed off once and for all |
robotdana
force-pushed
the
feature/improve-error-messaging
branch
from
06be9d1
to
e0e2910
Compare
robotdana
force-pushed
the
feature/improve-error-messaging
branch
5 times, most recently
from
5ecf371
to
446d734
Compare
|
The performance integration test was failing a lot since i merged #28, it looks like performance doesn't like being the first test run |
G-Rath
approved these changes
Oct 21, 2022
| Full report: | ||
| #{Lighthouse::Matchers.results_directory}/f60a563794dfeedda6feeab0ec4a011c6bd74ff9.json | ||
|
|
||
| To view this report, load this file into https://googlechrome.github.io/lighthouse/viewer/ |
G-Rath
force-pushed
the
feature/improve-error-messaging
branch
3 times, most recently
from
2e0406b
to
885818f
Compare
G-Rath
force-pushed
the
feature/improve-error-messaging
branch
8 times, most recently
from
7ae8e2c
to
4c3e415
Compare
G-Rath
force-pushed
the
feature/improve-error-messaging
branch
from
4c3e415
to
ee98817
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide some visibility into why and how much a score is worse than it was