-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat/fix]: A Star Search Improvement #1566
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few improvements.
test.cpp: In lambda function:
test.cpp:558:31: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
558 | for (int i = 0; i < first.get_size(); ++i) {
| ~~^~~~~~~~~~~~~~~~~~
test.cpp:559:35: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
559 | for (int j = 0; j < first.get_size(); ++j) {
| ~~^~~~~~~~~~~~~~~~~~
test.cpp:562:39: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
562 | for (int k = 0; k < second.get_size(); ++k) {
| ~~^~~~~~~~~~~~~~~~~~~
test.cpp:563:43: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
563 | for (int l = 0; l < second.get_size(); ++l) {
| ~~^~~~~~~~~~~~~~~~~~~
test.cpp: In lambda function:
test.cpp:666:31: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
666 | for (int i = 0; i < first.get_size(); ++i) {
| ~~^~~~~~~~~~~~~~~~~~
test.cpp:667:35: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
667 | for (int j = 0; j < first.get_size(); ++j) {
| ~~^~~~~~~~~~~~~~~~~~
test.cpp:670:39: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
670 | for (int k = 0; k < second.get_size(); ++k) {
| ~~^~~~~~~~~~~~~~~~~~~
test.cpp:671:43: error: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
671 | for (int l = 0; l < second.get_size(); ++l) {
| ~~^~~~~~~~~~~~~~~~~~~
shell returned 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution! 👍 🎉
Description of Change
A Star Search Improvement:
Checklist
Notes: