Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Finding no. of digits in a Number #1497

Merged
merged 28 commits into from
Sep 3, 2021
Merged

feat: Finding no. of digits in a Number #1497

merged 28 commits into from
Sep 3, 2021

Conversation

aminoxix
Copy link
Member

@aminoxix aminoxix commented May 25, 2021

Description of Change

The changes I made here, to commit the code for finding the no. of digits in a Number.
Ref. to some close PR #1491 & #1492

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes: #1491 & #1492 are closed.. This can be treat as new commit, I delete their remote also, so the changes can only be done to the right folder, nothing will be messed up..

@Panquesito7 Panquesito7 changed the title Finding no. of digits in a Number feat: Finding no. of digits in a Number May 25, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good work.

math/finding_number_of_digits_in_a_number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_digits_in_a_number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_digits_in_a_number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_digits_in_a_number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_digits_in_a_number.cpp Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 added enhancement New feature or request Proper Documentation Required requested to write the documentation properly requested changes changes required labels May 25, 2021
math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good work.

math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
@aminoxix aminoxix requested a review from Panquesito7 May 26, 2021 19:23
math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
@aminoxix
Copy link
Member Author

aminoxix commented Jun 2, 2021

@Panquesito7 : Done with all changes!

math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
math/finding_number_of_Digits_in_a_Number.cpp Outdated Show resolved Hide resolved
@Panquesito7 Panquesito7 removed the Proper Documentation Required requested to write the documentation properly label Jun 2, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. 😄


#include <cassert> /// for assert
#include <iostream> /// for IO operations

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add self-test implementations using assert (see the typical structure of a program as an example).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Panquesito7 : Help me for this! 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if I can help you, as you understand better your algorithm and your program, so you should be able to do it. However, if you have any doubts, let me know.🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Panquesito7 : Yep, for sure, you're right! :)

@stale
Copy link

stale bot commented Jul 8, 2021

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added stale Author has not responded to the comments for over 2 weeks and removed stale Author has not responded to the comments for over 2 weeks labels Jul 8, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Awesome work, @Amino19! Thanks for your contribution! 😄👍🎉
Note for maintainers: the other files are modified automatically by the CI.

@Panquesito7 Panquesito7 removed the requested changes changes required label Sep 1, 2021
@Panquesito7 Panquesito7 added the approved Approved; waiting for merge label Sep 1, 2021
@Panquesito7 Panquesito7 merged commit 341ed50 into TheAlgorithms:master Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved; waiting for merge enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants