-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Finding no. of digits in a Number #1497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Good work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Good work.
@Panquesito7 : Done with all changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. 😄
|
||
#include <cassert> /// for assert | ||
#include <iostream> /// for IO operations | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add self-test implementations using assert
(see the typical structure of a program as an example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Panquesito7 : Help me for this! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if I can help you, as you understand better your algorithm and your program, so you should be able to do it. However, if you have any doubts, let me know.🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Panquesito7 : Yep, for sure, you're right! :)
This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Awesome work, @Amino19! Thanks for your contribution! 😄👍🎉
Note for maintainers: the other files are modified automatically by the CI.
Description of Change
The changes I made here, to commit the code for finding the no. of digits in a Number.
Ref. to some close PR #1491 & #1492
Checklist
Notes: #1491 & #1492 are closed.. This can be treat as new commit, I delete their remote also, so the changes can only be done to the right folder, nothing will be messed up..