Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change a singular check so that #397 works. #400

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Change a singular check so that #397 works. #400

merged 1 commit into from
Jun 8, 2023

Conversation

jonahnm
Copy link
Contributor

@jonahnm jonahnm commented Jun 8, 2023 •
edited by LeeTwentyThree
Loading

Changes made in this pull request

  • if (uGUI.isMainLevel) changed to if(PDAEncyclopedia.initialized)

Breaking changes

  • None (as far as I know)

@jonahnm jonahnm mentioned this pull request Jun 8, 2023
Merged
@LeeTwentyThree
Copy link
Member

Edited the cursed formatting of the original description

LeeTwentyThree
LeeTwentyThree approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@LeeTwentyThree LeeTwentyThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a much safer check than the original one which was rather arbitrary.

@LeeTwentyThree
Copy link
Member

I noticed there are other methods that still use uGUI.isMainLevel as a check. I think this is "good enough" but we should probably look into that further down the line.

@LeeTwentyThree LeeTwentyThree merged commit 93e2432 into SubnauticaModding:master Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeTwentyThree LeeTwentyThree LeeTwentyThree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonahnm @LeeTwentyThree