Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod Databank entries. #397

Merged
merged 30 commits into from
Jun 12, 2023

Conversation

jonahnm
Copy link
Contributor

@jonahnm jonahnm commented Jun 3, 2023

Changes made in this pull request

  • Handler to add databank entries for mods.

May need further testing.

@jonahnm
Copy link
Contributor Author

jonahnm commented Jun 3, 2023

Closes #326

@LeeTwentyThree
Copy link
Member

LeeTwentyThree commented Jun 3, 2023

@LeeTwentyThree LeeTwentyThree linked an issue Jun 3, 2023 that may be closed by this pull request
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Patchers/PDAEncyclopediaPatcher.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Patchers/PDAEncyclopediaTabPatcher.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Example mod/ConfigExamples.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Initializer.cs Outdated Show resolved Hide resolved
@jonahnm jonahnm requested a review from JKohlman June 4, 2023 00:50
@jonahnm
Copy link
Contributor Author

jonahnm commented Jun 8, 2023

Review needed.

@LeeTwentyThree
Copy link
Member

After loading into the game, I do not see any mod databank entries or any tab for that.

@LeeTwentyThree
Copy link
Member

This seems to work as intended with mods that explicitly call the RegisterMod method, however I imagined it would automatically add mod databank entries for mods that don't. I'm fine either way, just something that came to mind.

@jonahnm
Copy link
Contributor Author

jonahnm commented Jun 8, 2023

ECM forced me to make it that way.

Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Patchers/PDAEncyclopediaTabPatcher.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDataBankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/PDAHandler.cs Show resolved Hide resolved
Nautilus/Patchers/OptionsPanelPatcher.cs Outdated Show resolved Hide resolved
@LeeTwentyThree
Copy link
Member

ECM forced me to make it that way.

I doubt that happened but it's probably fine without automatic patching since that would clutter the tab with empty mod entries.

@jonahnm
Copy link
Contributor Author

jonahnm commented Jun 8, 2023

ECM forced me to make it that way.

I doubt that happened but it's probably fine without automatic patching since that would clutter the tab with empty mod entries.

Well, it's more they wanted me to.

@jonahnm
Copy link
Contributor Author

jonahnm commented Jun 8, 2023

Depends on #400.

Copy link
Member

@LeeTwentyThree LeeTwentyThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there.

Example mod/ConfigExamples.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDatabankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDatabankHandler.cs Outdated Show resolved Hide resolved
Nautilus/Patchers/PDAEncyclopediaTabPatcher.cs Outdated Show resolved Hide resolved
Nautilus/Handlers/ModDatabankHandler.cs Outdated Show resolved Hide resolved
Copy link
Member

@LeeTwentyThree LeeTwentyThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close.

Nautilus/Patchers/PDAEncyclopediaTabPatcher.cs Outdated Show resolved Hide resolved
Copy link
Member

@LeeTwentyThree LeeTwentyThree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@LeeTwentyThree LeeTwentyThree merged commit 2996e3f into SubnauticaModding:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mod Databank Entries system
4 participants