tablefunction: csv.trim_space error report

Signed-off-by: ricky <[email protected]>

fe/fe-core/src/main/java/com/starrocks/catalog/TableFunctionTable.java

@@ -306,7 +306,14 @@ private void parseProperties() throws DdlException {
         }
 
         if (properties.containsKey(PROPERTY_CSV_TRIM_SPACE)) {
-            csvTrimSpace = Boolean.parseBoolean(properties.get(PROPERTY_CSV_TRIM_SPACE));
+            String property = properties.get(PROPERTY_CSV_TRIM_SPACE);
+            if (property.equalsIgnoreCase("true")) {
+                csvTrimSpace = true;
+            } else if (property.equalsIgnoreCase("false")) {
+                csvTrimSpace = false;
+            } else {
+                throw new DdlException("illegal value of csv.skip_header: " + property + ", only true/false allowed");
+            }
         }
     }
 

fe/fe-core/src/test/java/com/starrocks/catalog/TableFunctionTableTest.java

@@ -212,4 +212,24 @@ public void testIllegalDelimiter() throws DdlException {
                     () -> new TableFunctionTable(properties));
         }
     }
+
+    @Test
+    public void testIllegalCSVTrimSpace() throws DdlException {
+        new MockUp<HdfsUtil>() {
+            @Mock
+            public void parseFile(String path, BrokerDesc brokerDesc, List<TBrokerFileStatus> fileStatuses) throws UserException {
+            }
+        };
+
+        Map<String, String> properties = newProperties();
+        properties.put("csv.trim_space", "FALSE");
+
+        ExceptionChecker.expectThrowsNoException(() -> new TableFunctionTable(properties));
+
+        properties.put("csv.trim_space", "FALS");
+
+        ExceptionChecker.expectThrowsWithMsg(DdlException.class,
+                "illegal value of csv.skip_header: FALS, only true/false allowed",
+                () -> new TableFunctionTable(properties));
+    }
 }