[Enhancement] files() csv.trim_space error report
#44740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wyb
reviewed
May 28, 2024
fe/fe-core/src/main/java/com/starrocks/catalog/TableFunctionTable.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/test/java/com/starrocks/catalog/TableFunctionTableTest.java
Outdated
Show resolved
Hide resolved
wyb
previously approved these changes
May 28, 2024
Signed-off-by: ricky <[email protected]>
rickif
force-pushed
the
fix/csv-trim-space-error
branch
from
3ef9327
to
f9b589a
Compare
meegoo
previously approved these changes
May 28, 2024
rickif
commented
May 28, 2024
fe/fe-core/src/main/java/com/starrocks/catalog/TableFunctionTable.java
Outdated
Show resolved
Hide resolved
Signed-off-by: ricky <[email protected]>
auto-merge was automatically disabled
May 28, 2024 10:43
Head branch was pushed to by a user without write access
rickif
commented
May 28, 2024
fe/fe-core/src/test/java/com/starrocks/catalog/TableFunctionTableTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: ricky <[email protected]>
wyb
approved these changes
May 28, 2024
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 6 / 6 (100.00%) file detail
|
HangyuanLiu
approved these changes
May 29, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 29, 2024
Signed-off-by: ricky <[email protected]> (cherry picked from commit 144b65c)
23 tasks
mergify bot
pushed a commit
that referenced
this pull request
May 29, 2024
Signed-off-by: ricky <[email protected]> (cherry picked from commit 144b65c) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/catalog/TableFunctionTable.java # fe/fe-core/src/test/java/com/starrocks/catalog/TableFunctionTableTest.java
41 tasks
meegoo
pushed a commit
that referenced
this pull request
Jun 7, 2024
… (#46374) Co-authored-by: ricky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
The
csv.trim_spaceproperty offiles()should be in bool type.Now, the
files()will not report any error even if we setcsv.trim_spaceas any illegal stringa.What I'm doing:
This PR fixes this issue. When an illegal values is set,
Access storage error. Error message: illegal value of csv.trim_space: a, only true/false allowedwill be reported.Fixes #42800
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: