Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow output_schema to validate non-object action output (int, bool, etc) #5319

Merged
merged 44 commits into from
Jul 18, 2022
Merged

Allow output_schema to validate non-object action output (int, bool, etc) #5319

Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
1bbf0be
protect more datatypes in output_value inspection
cognifloyd Aug 4, 2021
44874e4
add tests for output_schema validation
cognifloyd Aug 4, 2021
61f10a6
adjust test comments
cognifloyd Aug 4, 2021
a129c8d
Fix var usage
cognifloyd Aug 4, 2021
d12042b
Merge branch 'master' into patch-7
cognifloyd Aug 4, 2021
6524d74
Add recursive _get_masked_value function
cognifloyd Aug 6, 2021
3becc3e
return quickly if output_value[output_key] is wrong type
cognifloyd Aug 6, 2021
49508d2
Add coments explaining output_schema validating objects
cognifloyd Aug 6, 2021
dd05bc0
check for unhandled_keys before compiling regex
cognifloyd Aug 6, 2021
2bb40d7
Allow action output_schema to be a full jsonschema
cognifloyd Aug 6, 2021
8f830b6
Regenerate action schema for new action_output format
cognifloyd Aug 6, 2021
2bfc098
Merge branch 'master' into patch-7
cognifloyd Oct 5, 2021
6b02ed4
Merge branch 'master' into patch-7
cognifloyd Mar 29, 2022
6e7ec73
try simplifying output_schema
cognifloyd Mar 29, 2022
95062c0
turn runner output_schema into full jsonschema
cognifloyd Mar 29, 2022
2461a4d
turn test runner/action output_schema into full jsonschema
cognifloyd Mar 30, 2022
94e78b4
schema validation: inject defaults only if dependencies are met.
cognifloyd Mar 30, 2022
cc32381
schema validation: runner schema is always a full schema now
cognifloyd Mar 30, 2022
36cb3b1
adjust more output_schema tests
cognifloyd Mar 30, 2022
066ff8b
Complete output_schemas including additionalProperties
cognifloyd Mar 30, 2022
dd9e032
Clean up action_output_schema usage
cognifloyd Mar 30, 2022
10c828c
secret_masking typing fixes
cognifloyd Mar 30, 2022
cab0548
drop legacy partial object output_schema support
cognifloyd Mar 30, 2022
b904b12
Clarify why mask_output returns early
cognifloyd Mar 30, 2022
d15db88
Fix test output_schema in python_runner tests
cognifloyd Mar 30, 2022
3cf35af
Add more malformed output_schema tests
cognifloyd Mar 30, 2022
dc6af0e
More reliable output_schema._schema_is_valid
cognifloyd Mar 30, 2022
9dd7245
Refactor for clarity
cognifloyd Mar 30, 2022
5fc52f2
add changelog entry
cognifloyd Mar 30, 2022
0f52eda
revert action_output_schema additional_properties change
cognifloyd Mar 30, 2022
4144013
add test for top-level output secret masking
cognifloyd Mar 30, 2022
398d273
Reduce duplication in output_schema tests
cognifloyd Mar 30, 2022
accd679
Fix typo in ouptut_schema tests
cognifloyd Mar 30, 2022
dfad436
Fix issues with output_schema array handling
cognifloyd Mar 31, 2022
8e925d0
Add debug log for schema validation errors
cognifloyd Mar 31, 2022
91ddd42
test output_schema with additionalProperties schema
cognifloyd Mar 31, 2022
5618d34
fix output_schema with patternProperties schema
cognifloyd Mar 31, 2022
3e1a052
reformat with black
cognifloyd Mar 31, 2022
d5222eb
Merge branch 'master' into patch-7
cognifloyd Mar 31, 2022
c640f07
Merge branch 'master' into patch-7
cognifloyd Jul 5, 2022
6654603
Merge branch 'master' into patch-7
cognifloyd Jul 10, 2022
3bb046e
Merge branch 'master' into patch-7
cognifloyd Jul 10, 2022
975c242
highlight that the output_schema change is a breaking change
cognifloyd Jul 16, 2022
40c0a4e
Merge branch 'master' into patch-7
cognifloyd Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo in ouptut_schema tests
  • Loading branch information
@cognifloyd
cognifloyd committed Mar 30, 2022
commit accd6796e363996a537183623841b832a399dea3
4 changes: 2 additions & 2 deletions st2common/tests/unit/test_util_output_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"output_3": {"type": "string"},
"deep_output": {
"type": "object",
"parameters": {
"properties": {
"deep_item_1": {
"type": "string",
},
Expand Down Expand Up @@ -103,7 +103,7 @@
"output_3": {"type": "string", "secret": True},
"deep_output": {
"type": "object",
"parameters": {
"properties": {
"deep_item_1": {
"type": "string",
},
Expand Down