Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow output_schema to validate non-object action output (int, bool, etc) #5319

Merged
merged 44 commits into from
Jul 18, 2022
Merged

Allow output_schema to validate non-object action output (int, bool, etc) #5319

merged 44 commits into from
Jul 18, 2022

Commits on Aug 4, 2021

  1. protect more datatypes in output_value inspection

    @cognifloyd
    cognifloyd committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    1bbf0be View commit details
    Browse the repository at this point in the history

  2. add tests for output_schema validation

    @cognifloyd
    cognifloyd committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    44874e4 View commit details
    Browse the repository at this point in the history

  3. adjust test comments

    @cognifloyd
    cognifloyd committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    61f10a6 View commit details
    Browse the repository at this point in the history

  4. Fix var usage

    @cognifloyd
    cognifloyd committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    a129c8d View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into patch-7

    @cognifloyd
    cognifloyd authored Aug 4, 2021
    Configuration menu
    Copy the full SHA
    d12042b View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2021

  1. Add recursive _get_masked_value function 

    This should handle any nested objects/arrays etc.
We might need to adjust the output_schema to support non-objects
but that can be done separately, I hope.
    @cognifloyd
    cognifloyd committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    6524d74 View commit details
    Browse the repository at this point in the history

  2. return quickly if output_value[output_key] is wrong type

    @cognifloyd
    cognifloyd committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    3becc3e View commit details
    Browse the repository at this point in the history

  3. Add coments explaining output_schema validating objects

    @cognifloyd
    cognifloyd committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    49508d2 View commit details
    Browse the repository at this point in the history

  4. check for unhandled_keys before compiling regex

    @cognifloyd
    cognifloyd committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    dd05bc0 View commit details
    Browse the repository at this point in the history

  5. Allow action output_schema to be a full jsonschema

    @cognifloyd
    cognifloyd committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    2bb40d7 View commit details
    Browse the repository at this point in the history

  6. Regenerate action schema for new action_output format

    @cognifloyd
    cognifloyd committed Aug 6, 2021
    Configuration menu
    Copy the full SHA
    8f830b6 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Merge branch 'master' into patch-7

    @cognifloyd
    cognifloyd authored Oct 5, 2021
    Configuration menu
    Copy the full SHA
    2bfc098 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. Merge branch 'master' into patch-7

    @cognifloyd
    cognifloyd committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    6b02ed4 View commit details
    Browse the repository at this point in the history

  2. try simplifying output_schema

    @cognifloyd
    cognifloyd committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    6e7ec73 View commit details
    Browse the repository at this point in the history

  3. turn runner output_schema into full jsonschema

    @cognifloyd
    cognifloyd committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    95062c0 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. turn test runner/action output_schema into full jsonschema

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    2461a4d View commit details
    Browse the repository at this point in the history

  2. schema validation: inject defaults only if dependencies are met.

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    94e78b4 View commit details
    Browse the repository at this point in the history

  3. schema validation: runner schema is always a full schema now

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    cc32381 View commit details
    Browse the repository at this point in the history

  4. adjust more output_schema tests

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    36cb3b1 View commit details
    Browse the repository at this point in the history

  5. Complete output_schemas including additionalProperties

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    066ff8b View commit details
    Browse the repository at this point in the history

  6. Clean up action_output_schema usage

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    dd9e032 View commit details
    Browse the repository at this point in the history

  7. secret_masking typing fixes

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    10c828c View commit details
    Browse the repository at this point in the history

  8. drop legacy partial object output_schema support

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    cab0548 View commit details
    Browse the repository at this point in the history

  9. Clarify why mask_output returns early

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    b904b12 View commit details
    Browse the repository at this point in the history

  10. Fix test output_schema in python_runner tests

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    d15db88 View commit details
    Browse the repository at this point in the history

  11. Add more malformed output_schema tests

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    3cf35af View commit details
    Browse the repository at this point in the history

  12. More reliable output_schema._schema_is_valid 

    "type" is not required, so relying on that is likely to run into edge cases.
Instead, validate the schema before validating with the schema.
    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    dc6af0e View commit details
    Browse the repository at this point in the history

  13. Refactor for clarity

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    9dd7245 View commit details
    Browse the repository at this point in the history

  14. add changelog entry

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    5fc52f2 View commit details
    Browse the repository at this point in the history

  15. revert action_output_schema additional_properties change

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    0f52eda View commit details
    Browse the repository at this point in the history

  16. add test for top-level output secret masking

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    4144013 View commit details
    Browse the repository at this point in the history

  17. Reduce duplication in output_schema tests

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    398d273 View commit details
    Browse the repository at this point in the history

  18. Fix typo in ouptut_schema tests

    @cognifloyd
    cognifloyd committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    accd679 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. Fix issues with output_schema array handling

    @cognifloyd
    cognifloyd committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    dfad436 View commit details
    Browse the repository at this point in the history

  2. Add debug log for schema validation errors

    @cognifloyd
    cognifloyd committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    8e925d0 View commit details
    Browse the repository at this point in the history

  3. test output_schema with additionalProperties schema

    @cognifloyd
    cognifloyd committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    91ddd42 View commit details
    Browse the repository at this point in the history

  4. fix output_schema with patternProperties schema

    @cognifloyd
    cognifloyd committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    5618d34 View commit details
    Browse the repository at this point in the history

  5. reformat with black

    @cognifloyd
    cognifloyd committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    3e1a052 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into patch-7

    @cognifloyd
    cognifloyd authored Mar 31, 2022
    Configuration menu
    Copy the full SHA
    d5222eb View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Merge branch 'master' into patch-7

    @cognifloyd
    cognifloyd authored Jul 5, 2022
    Configuration menu
    Copy the full SHA
    c640f07 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2022

  1. Merge branch 'master' into patch-7

    @cognifloyd
    cognifloyd authored Jul 10, 2022
    Configuration menu
    Copy the full SHA
    6654603 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into patch-7

    @cognifloyd
    cognifloyd authored Jul 10, 2022
    Configuration menu
    Copy the full SHA
    3bb046e View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2022

  1. highlight that the output_schema change is a breaking change

    @cognifloyd
    cognifloyd committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    975c242 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2022

  1. Merge branch 'master' into patch-7

    @cognifloyd
    cognifloyd authored Jul 18, 2022
    Configuration menu
    Copy the full SHA
    40c0a4e View commit details
    Browse the repository at this point in the history