Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak synchronous memcpy implementation #1809

Merged
merged 29 commits into from
Feb 18, 2020
Merged

Tweak synchronous memcpy implementation #1809

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
6848b7d
Fix late-coming issues.
AlexVlx Dec 7, 2019
86936d1
Update hip_runtime_api.h
AlexVlx Dec 7, 2019
002f2d2
use launch_fence instead of barrier_bit
jeffdaily Dec 9, 2019
6bf31e9
missing HipTest::freeArrays in hipMemcpyWithStream.cpp
jeffdaily Dec 9, 2019
86f627a
Merge pull request #1727 from jeffdaily/feature_memcpy_the_2nd
AlexVlx Dec 9, 2019
c2780ca
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP …
AlexVlx Dec 15, 2019
17e7007
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP …
AlexVlx Jan 23, 2020
ae950bd
Clean up noise.
AlexVlx Jan 23, 2020
125960b
Clean up more noise.
AlexVlx Jan 23, 2020
2ec8e34
Clean up even more noise.
AlexVlx Jan 23, 2020
c5a2fda
Final clean up.
AlexVlx Jan 23, 2020
9e2326b
Tweak synchronous memcpy.
AlexVlx Jan 23, 2020
a759682
Correct failed appy.
AlexVlx Jan 23, 2020
1a55cb4
Try to improve D2D.
AlexVlx Jan 23, 2020
187815d
No need for `hsa_memory_copy`, it's slow.
AlexVlx Jan 23, 2020
f7f3caf
Correct typo
AlexVlx Jan 23, 2020
a5b3e39
Correctly handle locked pointers.
AlexVlx Jan 24, 2020
638a09f
Remove dead code
AlexVlx Jan 29, 2020
aaa19e5
Guard one remaining danger-zone.
AlexVlx Jan 29, 2020
969e3bc
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP …
AlexVlx Jan 30, 2020
491d4f7
Use owner type as opposed to pointer type do decide copy direction.
AlexVlx Jan 30, 2020
a7de6b7
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP …
AlexVlx Jan 30, 2020
e1988a6
Handle degenerate case where an IPC pointer may be hoovered in.
AlexVlx Feb 3, 2020
9bfc9a4
Degenerate case should not be handled.
AlexVlx Feb 5, 2020
56af960
Tweak D2H for cases where LargeBAR is available.
AlexVlx Feb 5, 2020
b07b411
Fix typo.
AlexVlx Feb 5, 2020
08ed04d
Fix typo 2.
AlexVlx Feb 5, 2020
cc19247
Merge branch 'feature_memcpy_the_2nd' of https://github.com/ROCm-Deve…
AlexVlx Feb 16, 2020
5110eb3
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP …
AlexVlx Feb 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove dead code
  • Loading branch information
@AlexVlx
AlexVlx authored Jan 29, 2020
commit 638a09feee5e402d3bcf66e97c82d4e5f3606bc9
4 changes: 0 additions & 4 deletions src/hip_memory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,10 +302,6 @@ void generic_copy(void* __restrict dst, const void* __restrict src, size_t n,
return do_std_memcpy(dst, src, n);
}

std::unique_ptr<void, void (*)(void*)> lck0{
nullptr, [](void* p) { hsa_amd_memory_unlock(p); }};
std::unique_ptr<void, void (*)(void*)> lck1{nullptr, lck0.get_deleter()};

switch (si.type) {
case HSA_EXT_POINTER_TYPE_HSA:
if (di.type == HSA_EXT_POINTER_TYPE_HSA) {
Expand Down