Tweak synchronous memcpy implementation #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use launch_fence instead of barrier_bit
…into feature_memcpy_the_2nd
…into feature_memcpy_the_2nd
…into feature_memcpy_the_2nd
…into feature_memcpy_the_2nd
|
FYI jenkins build 15 failed and 17 failed, but build 16 succeeded. I believe this PR is actually passing CI now if we could try kicking off another try. |
Done. build 18 is in progress now. |
|
@gargrahul did something change recently? I'm seeing this error in the CI logs: |
SarbojitAMD
reviewed
Feb 6, 2020
src/hip_memory.cpp
Outdated
Comment on lines
207
to
211
| if (da.handle == 0 || sa.handle == 0) { // Handle degenerate case. | ||
| throwing_result_check(hsa_memory_copy(dst, src, n), | ||
| __FILE__, __func__, __LINE__); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Not sure if we still need this change as we have observed hangs in hsa_memory_copy().
There was a problem hiding this comment.
Ignore the comment missed your latest commit :)
|
Lets merge this in. |
…loper-Tools/HIP into feature_memcpy_the_2nd
…into feature_memcpy_the_2nd
mangupta
added
pr:needs_updates
mangupta
approved these changes
Feb 18, 2020
mangupta
pushed a commit
that referenced
this pull request
Feb 27, 2020
AryanSalmanpour
pushed a commit
to AryanSalmanpour/HIP
that referenced
this pull request
Feb 28, 2020
mangupta
pushed a commit
that referenced
this pull request
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing one can have issues on certain systems, therefore this limits use of direct memcpy via largeBAR to sizes where it is unequivocally better.
Also addresses SWDEV-220030.