Use pathlib.Path instead of plain string paths #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thirtytwobits should we merge this or should we wait? |
pavel-kirienko
added a commit
to OpenCyphal/nunavut
that referenced
this pull request
Mar 31, 2022
thirtytwobits
pushed a commit
to OpenCyphal/nunavut
that referenced
this pull request
Apr 8, 2022
* Address regression introduced by OpenCyphal/pydsdl#77 * Python 3.6 is no longer supported * MyPy * Fix path usage in tests * Drop Python 3.6 * Fix another test * Drop Python 3.6 from GitHub Actions, too * Restore Python 3.6 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not expected to break the API. Uniform path representation can be obtained using
.as_posix():This changeset also updates the test dependencies and drops Python 3.6 from the CI rig.
Fixes #76
Relates to OpenCyphal/nunavut#239 and OpenCyphal/nunavut#195